Skip to content

Fix Clifford identification tolerance propagation#374

Draft
qciaran wants to merge 1 commit into
devfrom
fix-clifford-identification-tolerances
Draft

Fix Clifford identification tolerance propagation#374
qciaran wants to merge 1 commit into
devfrom
fix-clifford-identification-tolerances

Conversation

@qciaran

@qciaran qciaran commented Jul 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • propagate caller-provided tolerances through matrix fallback and global-phase normalization
  • make the normalization threshold independently configurable when required
  • recognize identity rotations symmetrically around positive and negative multiples of tau
  • expose the Clifford identification API from pecos.analysis
  • make the deprecated pecos.tools.find_cliffs module re-export the canonical implementation instead of maintaining a duplicate

Validation

  • 64 focused Clifford identification tests pass
  • 75 combined Clifford and existing PyPHIR name-resolution tests pass
  • all canonical matrices round-trip through identification
  • conversion-table entries match table-disabled matrix fallback
  • boundary coverage includes negative-near-zero angles, positive and negative tau multiples, caller-selected tolerances, and configurable normalization thresholds
  • changed-file Ruff and Black checks pass
  • uv lock --check passes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants