Skip to content

[Meta] Typo fixes for 5.8 - #6761

Open
Amxx wants to merge 5 commits into
masterfrom
typo-fixes
Open

Amxx wants to merge 5 commits into
masterfrom
typo-fixes

Conversation

@Amxx

@Amxx Amxx commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

arr00 and others added 4 commits July 22, 2026 17:25
@Amxx Amxx added this to the 5.8 milestone Sep 11, 2026
@Amxx
Amxx requested a review from a team as a code owner September 11, 2026 08:43
@changeset-bot

changeset-bot Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 55d6c0a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Essentials

Run ID: 8a2975c0-69c0-45f6-ac11-b01ad6e0c98a

📥 Commits

Reviewing files that changed from the base of the PR and between c547cd4 and 5e21432.

📒 Files selected for processing (3)
  • README.md
  • contracts/governance/README.adoc
  • contracts/utils/cryptography/WebAuthn.sol

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


Walkthrough

The README Solidity example now uses ^0.8.24. The GovernorCrosschain documentation now references CrosschainRemoteExecutor. The WebAuthn inline assembly comment now uses typeIndex. Runtime behavior is unchanged.

Priority: ⬇️ Low

Change: Other

Merge Risk: ⚪ Minimal · up to 5e214

The PR only fixes typos in documentation and an inline comment, with no expected impact on runtime behavior.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided, so the description cannot be assessed for relevance to the changeset. Add a brief description that mentions the two typo corrections and the Solidity version update in README.md.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main changes as typo fixes and includes the relevant 5.8 context. It does not mention the README Solidity version update, but the title does not need to cover every ch…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch typo-fixes

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor
view gas comparison

Changes to gas costs

Contract Method Min (+/-) % Max (+/-) % Median (+/-) % Avg (+/-) %
$AccountECDSAMock isValidSignature 2829 0 0.00% ➖ 17677 0 0.00% ➖ 9697 0 0.00% ➖ 10421 -3 -0.03% ✔️
$AccountEIP7702Mock isValidSignature 3107 0 0.00% ➖ 15558 -12 -0.08% ✔️ 7796 0 0.00% ➖ 9316 -3 -0.03% ✔️
$AccountEIP7702Mock validateUserOp 7910 +30 +0.38% ❌ 39585 0 0.00% ➖ 10470 0 0.00% ➖ 19322 +10 +0.05% ❌
$AccountEIP7702WithModulesMock $_installModule 34953 0 0.00% ➖ 84284 -24 -0.03% ✔️ 78007 0 0.00% ➖ 65106 -1 -0.00% ✔️
$AccountEIP7702WithModulesMock installModule 41203 -12 -0.03% ✔️ 101330 0 0.00% ➖ 101330 0 0.00% ➖ 98656 -1 -0.00% ✔️
$AccountEIP7702WithModulesMock isModuleInstalled 2100 0 0.00% ➖ 12840 0 0.00% ➖ 12340 -30 -0.24% ✔️ 10542 -6 -0.06% ✔️
$AccountEIP7702WithModulesMock isValidSignature 3321 0 0.00% ➖ 20564 +12 +0.06% ❌ 14733 +6 +0.04% ❌ 14757 +4 +0.03% ❌
$AccountEIP7702WithModulesMock uninstallModule 16496 +24 +0.15% ❌ 20900 -24 -0.11% ✔️ 20228 -19 -0.09% ✔️ 19208 -6 -0.03% ✔️
$AccountERC7579HookedMock $_installModule 34009 0 0.00% ➖ 86671 -12 -0.01% ✔️ 80406 0 0.00% ➖ 61679 0 0.00% ➖
$AccountERC7579HookedMock execute 11574 0 0.00% ➖ 33863 0 0.00% ➖ 32173 +12 +0.04% ❌ 25795 +2 +0.01% ❌
$AccountERC7579HookedMock executeFromExecutor 14470 0 0.00% ➖ 37045 0 0.00% ➖ 35075 -12 -0.03% ✔️ 28773 -1 -0.00% ✔️
$AccountERC7579HookedMock installModule 40395 0 0.00% ➖ 105209 +24 +0.02% ❌ 69645 -36 -0.05% ✔️ 65108 -3 -0.00% ✔️
$AccountERC7579HookedMock isModuleInstalled 2100 0 0.00% ➖ 12840 0 0.00% ➖ 12325 -15 -0.12% ✔️ 11027 -8 -0.07% ✔️
$AccountERC7579HookedMock uninstallModule 18915 +12 +0.06% ❌ 36958 0 0.00% ➖ 23342 +12 +0.05% ❌ 26572 +3 +0.01% ❌
$AccountERC7579Mock $_installModule 34976 0 0.00% ➖ 84319 +12 +0.01% ❌ 78030 0 0.00% ➖ 65129 -1 -0.00% ✔️
$AccountERC7579Mock executeFromExecutor 12063 0 0.00% ➖ 34638 0 0.00% ➖ 25801 +6 +0.02% ❌ 25152 +2 +0.01% ❌
$AccountERC7579Mock installModule 41216 0 0.00% ➖ 84507 0 0.00% ➖ 67372 +12 +0.02% ❌ 64365 +4 +0.01% ❌
$AccountERC7579Mock isModuleInstalled 2100 0 0.00% ➖ 12840 0 0.00% ➖ 12370 0 0.00% ➖ 10552 +1 +0.01% ❌
$AccountERC7579Mock uninstallModule 16505 -12 -0.07% ✔️ 20932 -12 -0.06% ✔️ 20254 +10 +0.05% ❌ 19230 -5 -0.03% ✔️
$AccountERC7579Mock validateUserOp 17333 +12 +0.07% ❌ 52601 +12 +0.02% ❌ 21952 +12 +0.05% ❌ 30629 +12 +0.04% ❌
$AccountERC7913Mock isValidSignature 8663 0 0.00% ➖ 111024 0 0.00% ➖ 34588 0 0.00% ➖ 40713 -3 -0.01% ✔️
$AccountERC7913Mock validateUserOp 10175 0 0.00% ➖ 134864 +12 +0.01% ❌ 41736 +6 +0.01% ❌ 48979 +7 +0.01% ❌
$AccountMock isValidSignature 2722 0 0.00% ➖ 11418 -12 -0.10% ✔️ 6330 0 0.00% ➖ 6524 -5 -0.08% ✔️
$AccountMock validateUserOp 7910 +60 +0.76% ❌ 35329 +36 +0.10% ❌ 8870 +90 +1.03% ❌ 17370 +62 +0.36% ❌
$AccountMultiSignerMock $_rawSignatureValidation 2580 0 0.00% ➖ 31763 0 0.00% ➖ 4609 0 0.00% ➖ 11907 +55 +0.46% ❌
$AccountMultiSignerMock validateUserOp 21037 +12 +0.06% ❌ 150415 -12 -0.01% ✔️ 46620 -30 -0.06% ✔️ 59604 +1 +0.00% ❌
$AccountMultiSignerWeightedMock isValidSignature 2712 0 0.00% ➖ 120657 -12 -0.01% ✔️ 40181 -12 -0.03% ✔️ 54409 +6067 +12.55% ❌
$AccountMultiSignerWeightedMock validateUserOp 33531 -12 -0.04% ✔️ 144492 -22 -0.02% ✔️ 71240 +13746 +23.91% ❌ 72062 +4656 +6.91% ❌
$AccountP256Mock isValidSignature 2693 0 0.00% ➖ 29915 -12 -0.04% ✔️ 23490 0 0.00% ➖ 20587 0 0.00% ➖
$AccountP256Mock validateUserOp 7880 0 0.00% ➖ 48275 -12 -0.02% ✔️ 17626 -12 -0.07% ✔️ 24594 -8 -0.03% ✔️
$AccountRSAMock isValidSignature 26245 0 0.00% ➖ 94320 0 0.00% ➖ 86381 +24 +0.03% ❌ 64996 -2 -0.00% ✔️
$AccountRSAMock validateUserOp 27761 +12 +0.04% ❌ 118154 0 0.00% ➖ 87505 0 0.00% ➖ 77807 +4 +0.01% ❌
$AccountWebAuthnMock isValidSignature 2797 0 0.00% ➖ 35168 +12 +0.03% ❌ 24110 0 0.00% ➖ 23027 +2 +0.01% ❌
$AccountWebAuthnMock validateUserOp 7910 0 0.00% ➖ 59013 -12 -0.02% ✔️ 28364 -12 -0.04% ✔️ 31762 -8 -0.03% ✔️
$EIP712Verifier $_hashTypedDataV4 - - - - - - - - - 1440 +30 +2.13% ❌
$ERC20Permit [constructor] - - - - - - - - - 1150935 +12 +0.00% ❌
$ERC20TransferAuthorization authorizationState 3773 0 0.00% ➖ 3797 0 0.00% ➖ 3785 0 0.00% ➖ 3787 +1 +0.03% ❌
$ERC20TransferAuthorization cancelAuthorization(address,bytes32,bytes) 31772 0 0.00% ➖ 37485 0 0.00% ➖ 37479 +6 +0.02% ❌ 35581 +2 +0.01% ❌
$ERC20TransferAuthorization cancelAuthorization(address,bytes32,uint8,bytes32,bytes32) 13919 +12 +0.09% ❌ 31007 0 0.00% ➖ 31007 +6 +0.02% ❌ 26734 +5 +0.02% ❌
$ERC20TransferAuthorization receiveWithAuthorization(address,address,uint256,uint256,uint256,bytes32,bytes) 65288 0 0.00% ➖ 68513 +12 +0.02% ❌ 66895 0 0.00% ➖ 66898 +3 +0.00% ❌
$ERC20TransferAuthorization receiveWithAuthorization(address,address,uint256,uint256,uint256,bytes32,uint8,bytes32,bytes32) 27796 0 0.00% ➖ 61995 -12 -0.02% ✔️ 61972 -12 -0.02% ✔️ 50592 -4 -0.01% ✔️
$ERC20TransferAuthorization transferWithAuthorization(address,address,uint256,uint256,uint256,bytes32,bytes) 62720 0 0.00% ➖ 68445 0 0.00% ➖ 65583 +6 +0.01% ❌ 65583 +3 +0.00% ❌
$ERC20TransferAuthorization transferWithAuthorization(address,address,uint256,uint256,uint256,bytes32,uint8,bytes32,bytes32) 44795 0 0.00% ➖ 61918 0 0.00% ➖ 61895 0 0.00% ➖ 59053 -1 -0.00% ✔️
$ERC3009 authorizationState 3632 +12 +0.33% ❌ 3632 0 0.00% ➖ 3632 0 0.00% ➖ 3632 +3 +0.08% ❌
$ERC3009 cancelAuthorization 30999 +12 +0.04% ❌ 31011 0 0.00% ➖ 30999 -6 -0.02% ✔️ 31002 0 0.00% ➖
$ERC3009 receiveWithAuthorization 62345 +12 +0.02% ❌ 62368 0 0.00% ➖ 62351 0 0.00% ➖ 62354 +3 +0.00% ❌
$ERC721ConsecutiveMock [constructor] 3489393 -12 -0.00% ✔️ 3489405 -12 -0.00% ✔️ 3489405 -12 -0.00% ✔️ 3489401 -12 -0.00% ✔️
$ERC7739ECDSAMock [constructor] - - - - - - - - - 888565 -12 -0.00% ✔️
$ERC7739ECDSAMock isValidSignature 2729 0 0.00% ➖ 17578 0 0.00% ➖ 9598 0 0.00% ➖ 10349 -2 -0.02% ✔️
$ERC7739P256Mock isValidSignature 2593 0 0.00% ➖ 29838 0 0.00% ➖ 23401 +12 +0.05% ❌ 20500 +5 +0.02% ❌
$ERC7739RSAMock isValidSignature 26199 0 0.00% ➖ 94252 -24 -0.03% ✔️ 86325 +12 +0.01% ❌ 64945 -8 -0.01% ✔️
$GovernorNoncesKeyedMock $_useCheckedNonce(address,uint192,uint64) 23867 +12 +0.05% ❌ 24134 +12 +0.05% ❌ 24134 +12 +0.05% ❌ 24045 +12 +0.05% ❌
$GovernorNoncesKeyedMock $_useCheckedNonce(address,uint256) 23455 +12 +0.05% ❌ 23722 +12 +0.05% ❌ 23722 +12 +0.05% ❌ 23633 +12 +0.05% ❌
$GovernorNoncesKeyedMock $_useNonce(address,uint192) 7362 +12 +0.16% ❌ 24680 +12 +0.05% ❌ 7580 +12 +0.16% ❌ 13207 +12 +0.09% ❌
$GovernorNoncesKeyedMock $_useNonce(address) - - - - - - - - - 24237 +12 +0.05% ❌
$GovernorNoncesKeyedMock nonces(address,uint192) 3339 +12 +0.36% ❌ 3815 0 0.00% ➖ 3539 +12 +0.34% ❌ 3544 +9 +0.25% ❌
$GovernorQueueingFailedMock [constructor] 4508579 -12 -0.00% ✔️ 4508905 -12 -0.00% ✔️ 4508905 -12 -0.00% ✔️ 4508796 -12 -0.00% ✔️
$PaymasterERC20GuarantorMock $_postOpGasBudget 15280 +60 +0.39% ❌ 20024 -12 -0.06% ✔️ 20024 -12 -0.06% ✔️ 18443 +12 +0.07% ❌
$PaymasterERC20GuarantorMock $_prefund 24954 +12 +0.05% ❌ 64132 -12 -0.02% ✔️ 44543 0 0.00% ➖ 44543 0 0.00% ➖
$PaymasterERC20GuarantorMock $_validatePaymasterUserOp 72894 0 0.00% ➖ 89970 -12 -0.01% ✔️ 81432 -6 -0.01% ✔️ 81432 -6 -0.01% ✔️
$PaymasterERC20Mock $_postOpGasBudget - - - - - - - - - 15250 -30 -0.20% ✔️
$VotesTimestampMock [constructor] - - - - - - - - - 1448735 +12 +0.00% ❌
ERC2771Forwarder execute 40129 0 0.00% ➖ 48467 -12 -0.02% ✔️ 44087 0 0.00% ➖ 44116 -7 -0.02% ✔️
ERC2771Forwarder executeBatch 116533 -36 -0.03% ✔️ 174054 -24 -0.01% ✔️ 137621 -24 -0.02% ✔️ 138123 -24 -0.02% ✔️
ERC2771Forwarder verify 15326 0 0.00% ➖ 17470 0 0.00% ➖ 17446 -12 -0.07% ✔️ 16941 -5 -0.03% ✔️

This branch was successfully deployed

1 active deployment
certora — 55d6c0a2 Deployed Sep 24, 2026 by james-toussaint via verify (fv/specs/ERC20Wrapper.conf) #310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Inline comments, guides, and examples. ignore-changeset typo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants