Skip to content

AccountERC7579: document that isValidSignature has no native validation fallback #6708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BhariGowda wants to merge 2 commits into
base: master
Choose a base branch
from
Open

AccountERC7579: document that isValidSignature has no native validation fallback #6708

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d66f7a8
AccountERC7579: document that isValidSignature has no native validati…
BhariGowda Aug 21, 2026
aae186f
Merge branch 'master' into docs/account-erc7579-isvalidsignature-natspec
BhariGowda Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions contracts/account/extensions/draft-AccountERC7579.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,14 @@ abstract contract AccountERC7579 is Account, IERC1271, IERC7579Execution, IERC75
}

/**
* @dev Implement ERC-1271 through IERC7579Validator modules. If module based validation fails, fallback to
* "native" validation by the abstract signer.
* @dev Implement ERC-1271 through IERC7579Validator modules. The validator module is extracted from the first
* 20 bytes of the signature (see {_extractSignatureValidator}) and its return value is forwarded as-is.
* Returns `0xffffffff` if the signature is too short to extract a module, if that module is not installed as
* a validator, or if the call to it reverts.
*
* NOTE: Unlike {_validateUserOp}, this function does not fall back to "native" validation by the abstract
* signer. Signature validation is delegated to the modules only, matching {_rawSignatureValidation} being
* disabled in this contract.
*
* NOTE: when combined with {ERC7739}, resolution ordering may have an impact ({ERC7739} does not call super).
* Manual resolution might be necessary.
Expand Down
Loading