Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughExpanded the Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: James Toussaint <33313130+james-toussaint@users.noreply.github.com>
Co-authored-by: James Toussaint <33313130+james-toussaint@users.noreply.github.com>
Alternative to #6648.
The
IERC6372NatSpec was grabbed back then directly fromVotes.sol, where it's NatSpec does fit:clock()isvirtualthere and the context is voting checkpoints. Neither holds in the interface, and ERC-6372 never mentions checkpoints or voting.It also dropped the normative part of the spec:
clock()must be non-decreasing, andCLOCK_MODE()must return a URL-query-string descriptor with specified values. That is where I think the doc matters, since the return type is juststring.This rewrites both to describe the standard, and adds a contract-level
@devfor consistency with the other interfaces undercontracts/interfaces/(IERC5313,IERC6093).