Skip to content

4.6.6 - #662

Merged
MakinoharaShoko merged 14 commits into
mainfrom
dev
Oct 8, 2026
Merged

4.6.6#662
MakinoharaShoko merged 14 commits into
mainfrom
dev

Conversation

@MakinoharaShoko

Copy link
Copy Markdown
Member

No description provided.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T14:00:42.865300Z 4ac4746 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4ac474647e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

/** 上次保存(或打开时)的内容,内容没变就不保存,例如只是添加了一条空轨道 */
const lastTextRef = useRef(serializeAnimation(doc));

const debouncedSave = useMemo(() => debounce((next: IAnimationDocument) => saveRef.current(next), SAVE_DELAY), []);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Serialize animation saves to preserve edit order

When a user pauses for more than 300 ms between edits, the debounce can start another asynchronous file save while the previous saveRef.current promise is still pending. Since these requests are not queued, a slower earlier write can finish after a newer write and overwrite the latest animation on disk; the later cache mutation can also leave the editor displaying content that no longer matches the file. Chain or otherwise serialize these saves so completion order always follows edit order.

Useful? React with 👍 / 👎.

@MakinoharaShoko
MakinoharaShoko merged commit e319a4d into main Oct 8, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants