Skip to content

Animation v2 - #1043

Merged
MakinoharaShoko merged 8 commits into
devfrom
animation-v2
Oct 5, 2026
Merged

MakinoharaShoko merged 8 commits into
devfrom
animation-v2

Conversation

@MakinoharaShoko

Copy link
Copy Markdown
Member

实现 #1041 所述的 Animation v2,为 WebGAL 动画系统添加更多功能。

@MakinoharaShoko MakinoharaShoko linked an issue Oct 4, 2026 that may be closed by this pull request

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 04b30a74b0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +25 to +26
for (const track of tracks) {
setContainerValue(container, track.path, sampleTrack(track.points, time));

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Compose parallel writes to the same animation property

When two -parallel animations affect the same property, each timeline writes its independently calculated absolute value directly to the container. For example, two relative position.x += 100 animations are calculated with bases 0 and 100, so starting the second animation immediately jumps the display to 100 and its RAF updates overwrite the first animation rather than combining their deltas, even though the calculated stage state ends at 200. Parallel tracks targeting the same property need to be composited instead of using last-writer-wins assignments.

Useful? React with 👍 / 👎.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Deploying webgal-dev with  Cloudflare Pages  Cloudflare Pages

Latest commit: a8c6705
Status: ✅  Deploy successful!
Preview URL: https://709de67e.webgal-dev.pages.dev
Branch Preview URL: https://animation-v2.webgal-dev.pages.dev

View logs

@MakinoharaShoko
MakinoharaShoko merged commit f1e33d3 into dev Oct 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC:Animation v2

1 participant