Fix pr-triage workflow fromJSON handling - #3
Closed
Kyle-Ye wants to merge 1 commit into
Closed
Conversation
Use inputs.pr_number && fromJSON(inputs.pr_number) || github.event.pull_request.number to handle both workflow_dispatch and pull_request triggers correctly.
Member
Author
|
Closing legacy test PRs before the VersionedDocC GitHub Pages validation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the pr-triage workflow to properly handle both trigger types:
Problem:
fromJSON(inputs.pr_number)fails with "empty input" error when triggered by pull_request eventsinputs.pr_number || github.event.pull_request.numberdoesn't work due to GitHub's double input bugSolution:
Use conditional expression:
inputs.pr_number && fromJSON(inputs.pr_number) || github.event.pull_request.numberThis ensures:
workflow_dispatch: usesfromJSON(inputs.pr_number)pull_request: usesgithub.event.pull_request.numberdirectly