Skip Python loading for C++ shader plugins - #5
Open
nicolaspopravka wants to merge 1 commit into
Open
Conversation
Signed-off-by: Nicolas Popravka <nicolaspopravka@gmail.com>
nicolaspopravka
marked this pull request as ready for review
August 14, 2026 12:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compatibility:
patch
Issues/Tickets:
nicolaspopravka/usd-render-benchmark#26
Release notes comment:
Avoid warnings about missing Python modules when loading the MoonRay shader discovery and parser plugins.
Comments for the reviewer:
These libraries provide C++ plugins but no Python bindings. Registering an empty Python module token prevents
TfScriptModuleLoaderfrom trying to import nonexistentpxr.MoonrayShaderDiscoveryandpxr.MoonrayShaderParsermodules.I tested the change by building OpenMoonRay v2026.29.1 with the patched shader plugins. Shader and renderer discovery remained available, both missing-module warnings were absent, and the MoonRay,
hd_render, and stockusdrecordrender checks produced varying images.Validation run: https://github.com/nicolaspopravka/aswf-docker/actions/runs/31791756348
Look or scene setup change:
No expected look change.
Special notes for production:
Attention/Reviewers:
AI Assisted Development:
Assisted-by: OpenAI Codex / GPT-5
I used Codex to help investigate and implement this change and draft the initial description. I reviewed the code and validation results and take responsibility for the contribution.
Checklist: