Repository navigation
Send a cut-off network's ipctool report to openipc.ru with a 307 - #422
Conversation
From a network the TSPU cuts off, a report with a flash backup sent to openipc.org's port 80 froze at its first kilobytes and sat at "Sending 0%" (OpenIPC/ipctool#232). Port 80 now answers it with `307 http://openipc.ru/api/v1/reports`, whose port 80 proxies it back here, as it already does for ipctool's downloads (#397). 307 keeps the POST and its body. ipctool since OpenIPC/ipctool#233 waits for an answer to the headers before sending the body and follows a plain-HTTP 307, so a plain `ipctool upload` gets through from Russia with no --host. An older one reports the 307 and stops, which is quicker than the freeze. Install after #233 is in the published ipctool. Identify stays: a few kilobytes, which the freeze lets through.
PR Summary by QodoRedirect blocked-network report uploads through openipc.ru
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
Code Review by Qodo
1.
|
Qodo on #422: the geo block's comment still said port 80's report upload was left alone.
From a network the TSPU cuts off, a report with a flash backup sent to
openipc.org's port 80 froze at its first kilobytes and sat at
"Sending 0%" (OpenIPC/ipctool#232). Port 80 now answers it with
307 http://openipc.ru/api/v1/reports, whose port 80 proxies it backhere, as it already does for ipctool's downloads (#397). 307 keeps the
POST and its body.
ipctool since OpenIPC/ipctool#233 waits for an answer to the headers
before sending the body and follows a plain-HTTP 307, so a plain
ipctool uploadgets through from Russia with no --host. An older onereports the 307 and stops, which is quicker than the freeze. Install
after #233 is in the published ipctool. Identify stays: a few
kilobytes, which the freeze lets through.
service/run.sh test(deploytest) anddeploy/nginx/check-config.sh --seampass. The new probe:/api/v1/reports 307 (POST over HTTP from a blocked network).Do not
push-nginx.sh --applyuntil OpenIPC/ipctool#233 is merged and the rolling ipctool is on openipc.org.