Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1649,7 +1649,7 @@ CONFIG_USB_DEFAULT_PERSIST=y
# CONFIG_USB_R8A66597_HCD is not set
# CONFIG_USB_HCD_TEST_MODE is not set
CONFIG_USB_ANYKA_HCD=y
CONFIG_USB_AKOTG_HS_HCD=m
CONFIG_USB_AKOTG_HS_HCD=y
# CONFIG_USB_AKOTG_DMA is not set

#
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1656,7 +1656,7 @@ CONFIG_USB_DEFAULT_PERSIST=y
# CONFIG_USB_R8A66597_HCD is not set
# CONFIG_USB_HCD_TEST_MODE is not set
CONFIG_USB_ANYKA_HCD=y
CONFIG_USB_AKOTG_HS_HCD=m
CONFIG_USB_AKOTG_HS_HCD=y
# CONFIG_USB_AKOTG_DMA is not set

#
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1649,7 +1649,7 @@ CONFIG_USB_DEFAULT_PERSIST=y
# CONFIG_USB_R8A66597_HCD is not set
# CONFIG_USB_HCD_TEST_MODE is not set
CONFIG_USB_ANYKA_HCD=y
CONFIG_USB_AKOTG_HS_HCD=m
CONFIG_USB_AKOTG_HS_HCD=y
# CONFIG_USB_AKOTG_DMA is not set

#
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1677,7 +1677,7 @@ CONFIG_USB_DEFAULT_PERSIST=y
# CONFIG_USB_R8A66597_HCD is not set
# CONFIG_USB_HCD_TEST_MODE is not set
CONFIG_USB_ANYKA_HCD=y
CONFIG_USB_AKOTG_HS_HCD=m
CONFIG_USB_AKOTG_HS_HCD=y
# CONFIG_USB_AKOTG_DMA is not set

#
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1656,7 +1656,7 @@ CONFIG_USB_DEFAULT_PERSIST=y
# CONFIG_USB_R8A66597_HCD is not set
# CONFIG_USB_HCD_TEST_MODE is not set
CONFIG_USB_ANYKA_HCD=y
CONFIG_USB_AKOTG_HS_HCD=m
CONFIG_USB_AKOTG_HS_HCD=y
# CONFIG_USB_AKOTG_DMA is not set

#
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1655,7 +1655,7 @@ CONFIG_USB_DEFAULT_PERSIST=y
# CONFIG_USB_R8A66597_HCD is not set
# CONFIG_USB_HCD_TEST_MODE is not set
CONFIG_USB_ANYKA_HCD=y
CONFIG_USB_AKOTG_HS_HCD=m
CONFIG_USB_AKOTG_HS_HCD=y
# CONFIG_USB_AKOTG_DMA is not set

#
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1655,7 +1655,7 @@ CONFIG_USB_DEFAULT_PERSIST=y
# CONFIG_USB_R8A66597_HCD is not set
# CONFIG_USB_HCD_TEST_MODE is not set
CONFIG_USB_ANYKA_HCD=y
CONFIG_USB_AKOTG_HS_HCD=m
CONFIG_USB_AKOTG_HS_HCD=y
# CONFIG_USB_AKOTG_DMA is not set

#
Expand Down
3 changes: 3 additions & 0 deletions br-ext-chip-anyka/configs/ak3910_lite_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,8 @@ BR2_PACKAGE_MAJESTIC_WEBUI=y
BR2_PACKAGE_MBEDTLS_OPENIPC=y
BR2_PACKAGE_MOTORS=y
BR2_PACKAGE_OPUS_OPENIPC=y
# USB RTL8188FU (0bda:f179), which r8188eu binds but cannot tune.
BR2_PACKAGE_RTL8188FU_OPENIPC=y
BR2_PACKAGE_RDA5995_OPENIPC=y
BR2_PACKAGE_VTUND_OPENIPC=y
BR2_PACKAGE_YAML_CLI=y
3 changes: 3 additions & 0 deletions br-ext-chip-anyka/configs/ak3916ev300_lite_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -60,5 +60,8 @@ BR2_PACKAGE_MAJESTIC_WEBUI=y
BR2_PACKAGE_MBEDTLS_OPENIPC=y
BR2_PACKAGE_MOTORS=y
BR2_PACKAGE_OPUS_OPENIPC=y
# USB RTL8188FU (0bda:f179), which r8188eu binds but cannot tune.
BR2_PACKAGE_RTL8188FU_OPENIPC=y
BR2_PACKAGE_RDA5995_OPENIPC=y
BR2_PACKAGE_VTUND_OPENIPC=y
BR2_PACKAGE_YAML_CLI=y
3 changes: 3 additions & 0 deletions br-ext-chip-anyka/configs/ak3918_lite_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -63,5 +63,8 @@ BR2_PACKAGE_MAJESTIC_WEBUI=y
BR2_PACKAGE_MBEDTLS_OPENIPC=y
BR2_PACKAGE_MOTORS=y
BR2_PACKAGE_OPUS_OPENIPC=y
# USB RTL8188FU (0bda:f179), which r8188eu binds but cannot tune.
BR2_PACKAGE_RTL8188FU_OPENIPC=y
BR2_PACKAGE_RDA5995_OPENIPC=y
BR2_PACKAGE_VTUND_OPENIPC=y
BR2_PACKAGE_YAML_CLI=y
3 changes: 3 additions & 0 deletions br-ext-chip-anyka/configs/ak3918av130_lite_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -61,5 +61,8 @@ BR2_PACKAGE_MAJESTIC_WEBUI=y
BR2_PACKAGE_MBEDTLS_OPENIPC=y
BR2_PACKAGE_MOTORS=y
BR2_PACKAGE_OPUS_OPENIPC=y
# USB RTL8188FU (0bda:f179), which r8188eu binds but cannot tune.
BR2_PACKAGE_RTL8188FU_OPENIPC=y
BR2_PACKAGE_RDA5995_OPENIPC=y
BR2_PACKAGE_VTUND_OPENIPC=y
BR2_PACKAGE_YAML_CLI=y
3 changes: 3 additions & 0 deletions br-ext-chip-anyka/configs/ak3918ev200_lite_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -63,5 +63,8 @@ BR2_PACKAGE_MAJESTIC_WEBUI=y
BR2_PACKAGE_MBEDTLS_OPENIPC=y
BR2_PACKAGE_MOTORS=y
BR2_PACKAGE_OPUS_OPENIPC=y
# USB RTL8188FU (0bda:f179), which r8188eu binds but cannot tune.
BR2_PACKAGE_RTL8188FU_OPENIPC=y
BR2_PACKAGE_RDA5995_OPENIPC=y
BR2_PACKAGE_VTUND_OPENIPC=y
BR2_PACKAGE_YAML_CLI=y
3 changes: 3 additions & 0 deletions br-ext-chip-anyka/configs/ak3918ev300_lite_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -63,5 +63,8 @@ BR2_PACKAGE_MAJESTIC_WEBUI=y
BR2_PACKAGE_MBEDTLS_OPENIPC=y
BR2_PACKAGE_MOTORS=y
BR2_PACKAGE_OPUS_OPENIPC=y
# USB RTL8188FU (0bda:f179), which r8188eu binds but cannot tune.
BR2_PACKAGE_RTL8188FU_OPENIPC=y
BR2_PACKAGE_RDA5995_OPENIPC=y
Comment on lines +66 to +68

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Anyka camera changes lack hardware proof 📘 Rule violation ☼ Reliability

The Anyka defconfigs newly select two wireless drivers and build the USB host into the kernel
without evidence from a real camera. The PR reports only a QEMU boot and explicitly says no camera
was tested, so the changed firmware behavior on every Anyka image remains unverified on affected
hardware.
Agent Prompt
## Issue description
The PR changes firmware behavior across Anyka images but provides no real-camera verification; the only reported boot evidence comes from QEMU, and Wi-Fi association is explicitly untested.

## Fix Focus Areas
- br-ext-chip-anyka/configs/ak3918ev300_lite_defconfig[66-68]
- general/overlay/etc/init.d/S70vendor[7-13]

## Recommended Fix
Test an affected Anyka camera with the changed image, recording boot logs, USB host initialization, driver loading, Wi-Fi behavior, and the vendor-module startup message. Add the before/after hardware output to the PR description, or narrow the change to code that does not alter camera firmware behavior.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, and the PR stays a draft for that reason. Everything here has run only in the emulator; no Anyka camera has booted it. The reporter in #2639 can RAM-boot images over UART, and the hardware output will go in the description once they have. Until then the open questions are the ones listed there: RTL8188FU association, and whether rdawfmac attaches to a real RDA5995.

Comment thread
qodo-free-for-open-source-projects[bot] marked this conversation as resolved.
BR2_PACKAGE_VTUND_OPENIPC=y
BR2_PACKAGE_YAML_CLI=y
3 changes: 3 additions & 0 deletions br-ext-chip-anyka/configs/ak3918ev330_lite_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -63,5 +63,8 @@ BR2_PACKAGE_MAJESTIC_WEBUI=y
BR2_PACKAGE_MBEDTLS_OPENIPC=y
BR2_PACKAGE_MOTORS=y
BR2_PACKAGE_OPUS_OPENIPC=y
# USB RTL8188FU (0bda:f179), which r8188eu binds but cannot tune.
BR2_PACKAGE_RTL8188FU_OPENIPC=y
BR2_PACKAGE_RDA5995_OPENIPC=y
BR2_PACKAGE_VTUND_OPENIPC=y
BR2_PACKAGE_YAML_CLI=y
3 changes: 3 additions & 0 deletions br-ext-chip-anyka/configs/ak3918ev331_lite_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,8 @@ BR2_PACKAGE_MAJESTIC_WEBUI=y
BR2_PACKAGE_MBEDTLS_OPENIPC=y
BR2_PACKAGE_MOTORS=y
BR2_PACKAGE_OPUS_OPENIPC=y
# USB RTL8188FU (0bda:f179), which r8188eu binds but cannot tune.
BR2_PACKAGE_RTL8188FU_OPENIPC=y
BR2_PACKAGE_RDA5995_OPENIPC=y
BR2_PACKAGE_VTUND_OPENIPC=y
BR2_PACKAGE_YAML_CLI=y
8 changes: 7 additions & 1 deletion general/overlay/etc/init.d/S70vendor
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@ case "$1" in
start)
echo "Loading vendor modules..."
vendor=$(ipcinfo -v)
load_"$vendor" -i
# A family whose drivers are all built into the kernel ships no
# load script; say so rather than "load_<vendor>: not found".
if command -v load_"$vendor" >/dev/null; then
load_"$vendor" -i
else
echo "No load_$vendor on this image, nothing to load"
fi
;;

stop)
Expand Down
8 changes: 8 additions & 0 deletions general/overlay/etc/wireless/usb
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,14 @@ if [ "$1" = "atbm603x-generic-usb" ]; then
exit 0
fi

# Generic RDA5995
# rdawfmac waits for its chip at load and fails when none attaches, so its
# status is whether there is a wlan0.
if [ "$1" = "rda5995-generic" ]; then
modprobe rdawfmac
exit $?
fi

# GK7205V200 CamHi
if [ "$1" = "mt7601u-gk7205v200-camhi" ]; then
set_gpio 9 0
Expand Down
1 change: 1 addition & 0 deletions general/package/Config.in
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ source "$BR2_EXTERNAL_GENERAL_PATH/package/openipc-nfs-root/Config.in"
source "$BR2_EXTERNAL_GENERAL_PATH/package/opus-openipc/Config.in"
source "$BR2_EXTERNAL_GENERAL_PATH/package/osd-openipc/Config.in"
source "$BR2_EXTERNAL_GENERAL_PATH/package/quirc-openipc/Config.in"
source "$BR2_EXTERNAL_GENERAL_PATH/package/rda5995-openipc/Config.in"
source "$BR2_EXTERNAL_GENERAL_PATH/package/rockchip-osdrv-rv11xx/Config.in"
source "$BR2_EXTERNAL_GENERAL_PATH/package/rtl8188eus-openipc/Config.in"
source "$BR2_EXTERNAL_GENERAL_PATH/package/rtl8188fu-openipc/Config.in"
Expand Down
8 changes: 8 additions & 0 deletions general/package/rda5995-openipc/Config.in
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
config BR2_PACKAGE_RDA5995_OPENIPC
bool "rda5995-openipc"
depends on BR2_LINUX_KERNEL
help
Rdamicro RDA5995 USB wireless driver (rdawfmac, 1e04:8888), with
its firmware compiled in.

https://github.com/openipc/rda-wlan
21 changes: 21 additions & 0 deletions general/package/rda5995-openipc/rda5995-openipc.mk
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
################################################################################
#
# rda5995-openipc
#
################################################################################

RDA5995_OPENIPC_VERSION = 593c3184ae3f84c563b1704f6ad24879f122634b
RDA5995_OPENIPC_SITE = $(call github,openipc,rda-wlan,$(RDA5995_OPENIPC_VERSION))

# Rdamicro's permission notice heads every source file; the module
# declares GPL v2.
RDA5995_OPENIPC_LICENSE = ISC, GPL-2.0
RDA5995_OPENIPC_LICENSE_FILES = rdawlan/wland_linux.c

RDA5995_OPENIPC_MODULE_SUBDIRS = rdawlan
RDA5995_OPENIPC_MODULE_MAKE_OPTS = \
CONFIG_RDAWFMAC_USB=y \
CONFIG_RDAWFMAC_SDIO=

$(eval $(kernel-module))
$(eval $(generic-package))
Loading