Repository navigation
hisilicon-opensdk: bump to 963f7e9, GC2083 on hi3516cv6xx - #2577
Merged
Merged
Conversation
openipc-ai
requested review from
cronyx,
flyrouter and
viktorxda
as code owners
October 12, 2026 16:36
Collaborator
Author
|
/review |
Code Review by Qodo
1. New sensor support lacks camera evidence
|
![qodo-free-for-open-source-projects[bot]](https://avatars.githubusercontent.com/in/1068000?s=60&v=4){kind=small}
- hisilicon-opensdk: bump to 963f7e9 and build libsns_gc2083 for hi3516cv6xx (OpenIPC/openhisilicon#261), with the vendor's ISP tables, its colour tuning and the 0x400 black level. sys_config clocks the sensor at 27 MHz; ipctool already detects it (chip 0x2083). - hisilicon-osdrv-hi3516cv6xx: list gc2083 among the source-built sensors and in load_hisilicon's usage text. Not yet verified on hardware: OpenIPC/openhisilicon#260.
… resolved insert_ko passed SNS_TYPE0/1 to open_sys_config, and those only change with -sensor0/-sensor1, which S70vendor never passes. Every cv6xx camera was therefore configured as sc4336p whatever was detected or stored in the environment. sys_config takes the sensor clock and the MIPI/BT interface from that name, so an OS04D10 got 27 MHz instead of 24 and a BT656/BT1120 source was set up as MIPI. Use the resolved SENSOR unless a flag named one, as the ev200 script does.
openipc-ai
force-pushed
the
opensdk-gc2083-cv6xx
branch
from
October 13, 2026 17:35
3366992 to
0615833
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
963f7e9(sensor: add gc2083 for hi3516cv6xx (#260) openhisilicon#261) and buildlibsns_gc2083for hi3516cv6xx. The library carries the vendor driver's ISP tables, the vendor scene INI's colour tuning, and the0x400black level that fixes the magenta cast. sys_config clocks the sensor at 27 MHz, and ipctool already detects it (chip0x2083).load_hisiliconnow givesopen_sys_configthe sensor this boot resolved (-sensor0/ thesensorenv / the probe). Until nowinsert_kopassed the hard-codedsc4336pdefault unless-sensor0was given, andS70vendornever passes it. So every cv6xx camera got sc4336p's clock and interface: 27 MHz for an OS04D10 that needs 24, and MIPI for a BT656/BT1120 source. Explicit-sensor0/-sensor1still win. gc2083 is also listed among the source-built sensors and in the usage text.The bump also brings in OpenIPC/openhisilicon#259, which is docs only.
Testing: the library cross-compiles warning-free and passed openhisilicon's CI.
load_hisiliconpassesbusybox sh -n, and its sensor selection was checked for the no-flag,-sensor0and-sensor0 -sensor1cases. Nothing has run on a camera yet: we have no Hi3516CV610 board, and the reporter is testing an H2-52PGX in OpenIPC/openhisilicon#260. Board-specific power, I2C bus and MIPI setup for that board are not part of this PR.