Repository navigation
gk7202v300 xg521, hi3518ev300 xiaomi: stop installing the WDR/ profiles firmware removed - #204
Merged
Merged
Conversation
…es firmware removed Both profiles carry their own copy of the SoC's osdrv package, and both copies still install files/sensor/config/WDR/*.ini. The firmware dropped those profiles on 2026-10-10 (firmware#2567: majestic switches the linear profile to line WDR itself), so the glob matches nothing and the install step fails with "cannot stat .../WDR/*.ini". Neither board has built since. The copies now remove the directory, as the firmware's own package does. Both build locally against firmware master: headroom kernel 266 KB / rootfs 180 KB for xg521, 174 KB / 60 KB for the xiaomi.
openipc-ai
requested review from
cronyx,
flyrouter and
viktorxda
as code owners
October 14, 2026 16:00
Contributor
Author
|
/review |
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can switch off images and animations for a plain-text comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two device profiles carry their own copy of their SoC's osdrv package, and both copies still install
files/sensor/config/WDR/*.ini. The firmware dropped those profiles on 2026-10-10 (OpenIPC/firmware#2567), because majestic switches the linear profile to line WDR itself. The glob now matches nothing, and the install step fails:Neither
gk7202v300_lite_xg521norhi3518ev300_lite_xiaomi-mjsxj02hlhas built since. Both showed up red on #202, which builds every board.Both copies now remove the directory instead, as the firmware's own package does, so a rebuild over an earlier target doesn't keep the old files.
Tested
Both built locally with
builder.shagainst firmware master:gk7202v300_lite_xg521hi3518ev300_lite_xiaomi-mjsxj02hlNot covered here: the SigmaStar ssc333/ssc335/ssc338 failures on #202 were size-cap overflows, a separate problem. The
gk7205v200_wfbngfailures haven't been looked at.