Repository navigation
rostelecom-ipc8232swc-we: name the camera's RTL8188FU in wlandev again - #194
Merged
Merged
Conversation
With OpenIPC/firmware#2573 the radio stays beside the cable rather than instead of it: no wlanssid keeps eth0 on DHCP and QR onboarding listening, and a saved network keeps both up with the cable preferred.
openipc-ai
requested review from
cronyx,
flyrouter and
viktorxda
as code owners
October 12, 2026 12:21
PR Summary by QodoRestore RTL8188FU identification for the IPC8232SWC-WE
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can commit Qodo's fix in one click with committable suggestions (GitHub & GitLab) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after OpenIPC/firmware#2573. Without it, this brings back the bug #192 fixed: with
wlandevset and a network saved, firmware'sS40networkparks eth0 on a static 192.168.2.10.Problem
#192 dropped
fw_setenv wlandev rtl8188fu-genericfrom this camera's customizer because, with it, a wired IPC8232SWC-WE fell off its network. That also left the camera's own radio unnamed. An owner had to know the driver profile to turn WiFi on, and QR onboarding (S97qrscan, which runs only whenwlandevis set) never started.OpenIPC/firmware#2573 fixes the cause. With
wlandevset:wlanssid, eth0 keeps DHCP and QR onboarding listens;So the profile can name the RTL8188FU again.
Change
customizer.sh:fw_setenv wlandev rtl8188fu-generic, with a comment explaining why it's safe now.wlanssidandwlanpassstay commented out, so nothing joins a network until the owner configures one.Hardware tested on
The lab IPC8232SWC-WE (Hi3516EV300, RTL8188FU), with
wlandev=rtl8188fu-genericand the scripts from firmware#2573. Its evidence covers this exact configuration:Without
wlanssid, the camera keeps DHCP on eth0. That is #2572's behaviour, already on master, and it was verified on this camera.This branch's image was not rebuilt and flashed: the only change is one customizer line, and the customizer runs once on first boot.