[major] Refactor performance into core service#1628
Conversation
⌛ QEMU Validation PendingQEMU validation is pending on successful CI completion.
This comment was automatically generated by the Patina QEMU PR Validation workflow. |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
I haven't taken a look through this one yet, but similar to #1630, please try to keep each file about 80% (ideally 85%) coverage. |
|
@makubacki @Javagedes , i will add tests, but please review the changes for the new structure. The PR comment has a review guide since the commits are a bit of a mess due to the complexity of the refactor. |
squash to move to core
Cleanup and unify config
documentation documentation refresh Fix documentation
comment cleanup
|
I will be reviewing this today, please do not merge :) |
c02bac4 to
3c2e237
Compare
|
Note: Added |
Description
This PR addresses multiple issues with the current performance structure
This PR does the following
CorePerformance, following the pattern established by the timer and memory management.PerfortmanceMeasurementthat exposes this core support.Resolves: #1483
Reviewing this PR
This PR is intended to be merged as a single commit. The individual commits do attempt to follow a basic progression of the code rework but may be incomplete at the partial steps. Recommended review flow
PerformanceMeasurement)How This Was Tested
Tested for consistent performance data using
dpbefore and after refactor.Integration Instructions
Platforms must change use of
with_measurementsfrom thepatina_performanceto instead overridePlatformInfo::default_performance_config()