Skip to content

fix(kotlin-misk): remove nonexistent models project - #25026

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
axelray-dev:fix/kotlin-misk-settings-25021
Sep 30, 2026
Merged

wing328 merged 1 commit into
OpenAPITools:masterfrom
axelray-dev:fix/kotlin-misk-settings-25021

Conversation

@axelray-dev

@axelray-dev axelray-dev commented Sep 28, 2026 •

Copy link
Copy Markdown

Remove the stale :models project declaration from the Kotlin Misk settings template and regenerate the two checked-in Petstore samples. The focused generator test now verifies that generated settings do not declare the missing project.

Local validation passed: ./mvnw -pl modules/openapi-generator -am -Dtest=org.openapitools.codegen.kotlin.misk.KotlinMiskServerCodegenTest -Dsurefire.failIfNoSpecifiedTests=false test ran 2 tests with no failures, and bin/generate-samples.sh bin/configs/kotlin-misk.yaml bin/configs/kotlin-misk-config.yaml regenerated both samples successfully. Gradle itself was unavailable locally, and the full repository-wide build plus all-sample/docs generation were not run.

Fixes #25021

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Removes the stale :models project declaration from the Kotlin Misk settings template so the generated settings.gradle.kts no longer references a project that doesn't exist.

  • Regenerates both checked-in Petstore samples to match the updated template.
  • Adds a focused generator test asserting the generated settings don't declare :models.

Written for commit 6d7fb91. Summary will update on new commits.

Review in cubic

@axelray-dev
axelray-dev marked this pull request as ready for review September 29, 2026 21:28

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Re-trigger cubic

@wing328 wing328 added this to the 7.26.0 milestone Sep 30, 2026
@wing328
wing328 merged commit 1555c37 into OpenAPITools:master Sep 30, 2026
37 checks passed
@wing328

wing328 commented Sep 30, 2026

Copy link
Copy Markdown
Member

FYI. @andrewwilsonnew (author of kotlin-misk)

@andrewwilsonnew andrewwilsonnew left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [KOTLIN-MISK] Generated Gradle settings include nonexistent :models project

3 participants