Repository navigation
fix(kotlin-misk): remove nonexistent models project - #25026
Merged
wing328 merged 1 commit intoSep 30, 2026
Merged
Conversation
axelray-dev
marked this pull request as ready for review
September 29, 2026 21:28
Member
|
FYI. @andrewwilsonnew (author of kotlin-misk) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the stale
:modelsproject declaration from the Kotlin Misk settings template and regenerate the two checked-in Petstore samples. The focused generator test now verifies that generated settings do not declare the missing project.Local validation passed:
./mvnw -pl modules/openapi-generator -am -Dtest=org.openapitools.codegen.kotlin.misk.KotlinMiskServerCodegenTest -Dsurefire.failIfNoSpecifiedTests=false testran 2 tests with no failures, andbin/generate-samples.sh bin/configs/kotlin-misk.yaml bin/configs/kotlin-misk-config.yamlregenerated both samples successfully. Gradle itself was unavailable locally, and the full repository-wide build plus all-sample/docs generation were not run.Fixes #25021
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Removes the stale
:modelsproject declaration from the Kotlin Misk settings template so the generatedsettings.gradle.ktsno longer references a project that doesn't exist.:models.Written for commit 6d7fb91. Summary will update on new commits.