Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25016.
When an inline
oneOfmember has notitleand notype(for exampleallOfwith a single$refplusrequired), the variant name now falls back to the member's base type instead of passingnulltotoModelName. The type lookup also goes throughModelUtils.getType, which readstypesfor 3.1 schemas. The repro from #25016 now generatesWorkflowPathCondition(Box<models::WorkflowPathCondition>)and the crate compiles, and GitHub's current REST description, which failed onactions-policy-repo-conditions, generates without errors.The new
testOneOfMemberWithoutTitleOrTypefails on master with the NullPointerException.PR checklist
./mvnw clean packageand./bin/generate-samples.sh ./bin/configs/rust-*.yaml; no samples change.Summary by cubic
Fixes a Rust codegen NullPointerException when an inline
oneOfmember has neither atitlenor atype, such as anallOfwith a single$refplusrequired.Bug Fixes
nulltotoModelName; type lookup usesModelUtils.getType, which readstypesfor 3.1 schemas.WorkflowPathCondition(Box<models::WorkflowPathCondition>)and compiles, and GitHub's current REST description generates without errors.testOneOfMemberWithoutTitleOrType, which fails on master with the NullPointerException, and cleans up the files it generates.Written for commit 8a6d013. Summary will update on new commits.