test: add so password fields have the password OpenApi format - #22761
Mattias-Sehlstedt wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
1 issue found across 78 files
Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="modules/openapi-generator/src/test/resources/1_2/petstore-1.2/user">
<violation number="1" location="modules/openapi-generator/src/test/resources/1_2/petstore-1.2/user:248">
P1: Missing comma before newly added format makes the User model JSON invalid.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
befd1ca to
d7c42a7
Compare
|
From the logs it looks like the python pipeline issues are nothing that is tied to my changes |
8bd53b7 to
01d82e7
Compare
8a53d47 to
8c5d03b
Compare
be2d399 to
445554d
Compare
|
@cubic-dev-ai rerun review |
@Mattias-Sehlstedt I have started the AI code review. It will take a few minutes to complete. |
445554d to
96abbdf
Compare
96abbdf to
55765d7
Compare
55765d7 to
a463678
Compare
|
@cubic-dev-ai rerun review |
@Mattias-Sehlstedt I have started the AI code review. It will take a few minutes to complete. |
a463678 to
0dd23e9
Compare
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
0dd23e9 to
b83492f
Compare
b83492f to
32a5fe3
Compare
32a5fe3 to
90abf07
Compare
I saw that the AI-review comments on issues that are outside of scope but still relevant in general, so I thought they could be fixed so that they will not occur in the future.

(Image taken from #22726)
What I have done is that I have marked the password fields with
format: password, so that the generated code will properly use the generator functionality to censor the field when any explicit logging is invoked (e.g.,.toString()in Java).PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Marked password fields with OpenAPI
passwordformat so generated clients/servers mask them in logs and examples. Updated test specs and regenerated samples to apply the change.format: passwordto login password params andUser.passwordacross Swagger 1.2/2.0/3.0 petstore specs,jetbrainsAPI credential/webhook schemas, and the 3.0 snakecase‑discriminator request.User.toStringprints "*", TypeScript explode‑query serialization uses"password", and generatedopenapi.json/openapi.yamlinclude the format. Also removed outdatedwordnik2.0 specs from tests.Written for commit 90abf07. Summary will update on new commits.