Repository navigation
Support ! negation in .kickflipignore - #22
Merged
Merged
Conversation
Every line was passed to FileSystemGlobbing as an include, so "!.htaccess" matched a literal file named "!.htaccess" and a preceding ".*" silently ignored all root dotfiles (.htaccess, .user.ini). Lines starting with "!" now become excludes, re-including whatever another pattern ignored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
IgnoreServicepassed every.kickflipignoreline toFileSystemGlobbingas an include pattern. That library has no negation, so!.htaccessmatched a file literally named!.htaccess. A preceding.*then silently ignored every root dotfile.The Wootware Magento repo has
.*followed by!.htaccess, so neither.htaccessnor.user.inihas ever been deployed. PR deploys list them as Ignore.Change
!becomeAddExcludepatterns, re-including whatever another pattern ignored. Every other line is still an include..gitignore, order doesn't matter: a!pattern always wins. This is documented in the README.IsIgnored_NegatedPatternReincludesFilecovers.*with!.htaccessand!.user.ini..envand.kickflipignorestay ignored.dotnet test: 66 passed.Rollout note
Consumers install kickflip unpinned (
dotnet tool install kickflip), so the next published release takes effect on their next deploy. Deploys are diff-based, so a re-included file only uploads when a commit changes it. In the Magento repo, the next PR that touches.htaccesswill overwrite the live copy, which has been hand-edited until now.🤖 Generated with Claude Code