Skip to content

fix(android): preserve account-owned background uploads - #438

Open
veryCrunchy wants to merge 2 commits into
feature/account-credential-slotsfrom
fix/account-background-isolation
Open

fix(android): preserve account-owned background uploads#438
veryCrunchy wants to merge 2 commits into
feature/account-credential-slotsfrom
fix/account-background-isolation

Conversation

@veryCrunchy

@veryCrunchy veryCrunchy commented Sep 1, 2026

Copy link
Copy Markdown
Member

What changed

  • resolve queued Deck attachment uploads through their persisted account owner instead of the active account
  • load that account's credential without changing account selection
  • fail closed when the account is removed or the loaded credential does not match the persisted owner
  • retain the existing encrypted account-scoped queue and upload ambiguity handling

Why

A queued upload for account A was permanently marked failed and its persisted URI capability was released when account B became active. The durable store already recorded A as the owner, but the worker ignored it when choosing credentials.

Validation

On the dedicated Linux build host, from exact parent #436 head cd2b6de4156e42c9be02840d264790dc5c23a4e4:

Limits

  • deterministic tests cover same-server accounts, exact credential selection, missing-owner refusal, and credential mismatch refusal
  • the existing Android instrumented durable-store test covers two accounts with the same remote upload path, but this pass did not start an emulator or repeat that unchanged test
  • no live Nextcloud upload was performed

Found by the code-first account-isolation audit. Depends on #436.

@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #438 / NC Native September 1, 2026 20:57 Destroyed
@obiente-cloud

obiente-cloud Bot commented Sep 1, 2026

Copy link
Copy Markdown

Obiente preview

NC Native · 5fee12ef91fc · Ready

Open preview

View in Obiente

Obiente updates this comment as the preview changes.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-01T21:58:56.323238Z 5fee12e New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@veryCrunchy veryCrunchy changed the title fix/account background isolation fix(android): preserve account-owned background uploads Sep 1, 2026
@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #438 / NC Native September 1, 2026 20:58 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant