Skip to content

fix(android): guard recovered writeback mutations - #435

Open
veryCrunchy wants to merge 3 commits into
mainfrom
fix/android-writeback-mutation-guard
Open

fix(android): guard recovered writeback mutations#435
veryCrunchy wants to merge 3 commits into
mainfrom
fix/android-writeback-mutation-guard

Conversation

@veryCrunchy

Copy link
Copy Markdown
Member

What changed

  • guard rename, move, and delete against both active writebacks and durable ready manifests
  • block exact recovered paths and ancestor mutations after process restart
  • keep unrelated document mutations available
  • extract writeback recovery ownership from the DocumentsProvider into a bounded component
  • add unit coverage for path ownership and instrumentation coverage for process-restored manifests

Validation

  • focused AndroidVirtualFileProxyCallbackTest
  • :androidApp:compileDebugKotlin
  • :androidApp:assembleDebugAndroidTest
  • Kotlin architecture checks
  • repository hygiene after binding this PR number in the changelog fragment

Evidence limit

The isolated build-host emulator could not start because /dev/kvm is unavailable. The instrumentation APK compiles, but the process-restored device test still needs execution on a KVM-capable host or device.

Found by the continuing code-first reliability audit.

@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #435 / NC Native September 1, 2026 19:39 Destroyed
@obiente-cloud

obiente-cloud Bot commented Sep 1, 2026

Copy link
Copy Markdown

Obiente preview

NC Native · 834497f0764d · Ready

Open preview

View in Obiente

Obiente updates this comment as the preview changes.

@veryCrunchy
veryCrunchy marked this pull request as ready for review September 1, 2026 19:40
@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #435 / NC Native September 1, 2026 19:40 Destroyed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-01T19:45:40.053862Z 063141e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 063141e1c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant