Skip to content

fix(offline): guard offline generations from stale workers - #427

Open
veryCrunchy wants to merge 2 commits into
mainfrom
fix/offline-download-generation-recovery
Open

fix(offline): guard offline generations from stale workers#427
veryCrunchy wants to merge 2 commits into
mainfrom
fix/offline-download-generation-recovery

Conversation

@veryCrunchy

Copy link
Copy Markdown
Member

What changed

  • revalidate the persisted removal job, current pin intent, and expected generation before deleting an offline file
  • keep a newly repinned file when an older removal worker resumes
  • prevent a superseded download from deleting the last valid generation used by a newer refresh
  • persist the authoritative generation before deleting old unreferenced content
  • keep physical deletion failures retryable

Validation

  • focused AndroidFileOfflineRemovalTest
  • focused AndroidFileOfflineDownloadCompletionTest
  • bash tools/check-kotlin-architecture.sh
  • bash tools/check-repository.sh

Limits

This protects the Android offline pin queue. Broader transfer checkpoints, upload recovery, conflict presentation, and cancellation recovery remain separate work.

Advances #116

@obiente-cloud
obiente-cloud Bot temporarily deployed to Obiente Preview / PR #427 / NC Native September 1, 2026 18:08 Destroyed
@obiente-cloud

obiente-cloud Bot commented Sep 1, 2026

Copy link
Copy Markdown

Obiente preview

NC Native · 6d1b4a9c145f · Ready

Open preview

View in Obiente

Obiente updates this comment as the preview changes.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-01T18:23:36.417605Z 6d1b4a9 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 6d1b4a9c14

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant