Repository navigation
Take link-check renderer versions from requirements.txt - #2945
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/link_check/requirements.txtrepeated four pins fromrequirements.txt, and a test failed whenever they drifted. Dependabot only bumps the root file, so every Markdown or pymdown bump broke lint (#2939 needed a manual sync).The subset file now lists package names only and takes versions with
-c ../../requirements.txt. pip resolves that path relative to the file, so the workflows and the CONTRIBUTING install command work unchanged. The test now checks that the subset has no pins of its own and that every package in it is pinned inrequirements.txt.Checked locally: pip resolves the same versions as the root file, and
test:link-checkandtest:workflow-approvalspass.