refactor coder credentials to load classes dynamically - #967
Open
johrstrom wants to merge 5 commits into
Open
Conversation
johrstrom
commented
Aug 25, 2026
| def initialize(auth_url, dir) | ||
| @auth_url = auth_url | ||
| @dir = dir | ||
| class OpenstackCredentials < CredentialsInterface |
Contributor
Author
There was a problem hiding this comment.
Note that typical ruby classes correspond to the file name with _ being transformed into capitalizations.
I.e., this file really should have been open_stack_credentials with the classname OpenStackCredentials.
So I had to change the classname so that the configuration of openstack continues to work (otherwise it would have to be changed to open_stack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This changes the way the coder adapter's credentials are loaded so that they can be dynamically loaded at runtime without using a predefined case statement to load them. That is, users/centers can define these classes then just utilize them without contribution to this library.
Related issue
Closes #___ (if applicable)
Testing
Checklist
Anything else?
@andrejcermak & @Satyam-Captain FYI