Repository navigation
Conversation
DorianMAG
force-pushed
the
18.0-fix-web_timeline-new
branch
from
October 5, 2026 14:21
d9cd207 to
bc67d71
Compare
flotho
approved these changes
Oct 5, 2026
flotho
left a comment
flotho
left a comment
Member
There was a problem hiding this comment.
Easy code review
- successfully tested locally
aligned with the default behaviour
DorianMAG
force-pushed
the
18.0-fix-web_timeline-new
branch
from
October 6, 2026 06:22
bc67d71 to
7ee193f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "open_popup_action" option should also apply to a new record, just as it does for editing.
web/web_timeline/static/src/views/timeline/timeline_controller.esm.js
Line 104 in b405af9