Repository navigation
[20.0][MIG] web_environment_ribbon: Migration to 20.0 - #3687
Conversation
ribbon_test_environment -> web_environment_ribbon
…ow top menu visibility
Set correct z-index on ribbon Move position accordingly Cf OCA#191
* [IMP] web_environment_ribbon: add color customization The ribbon color and background-color can be modified through system parameters: * ribbon.color * ribbon.background.color Added Copyright in .js Delete duplicate entries in css
By creating the ribbon div on the fly, this module doesn't depend anymore on the webclient structure.
…(eg db_name) (OCA#621) * [ADD] .eggs in gitignore * [IMP] Web Environment Ribbon: add backend This commit adds a simple bakend to facilitate inheritance * [IMP] Web Environment Ribbon: add the databse name This commit adds the database name under the ribbon name, in the ribbon * [IMP] Web Environment Ribbon: prepare method for ribbon name * [IMP] README: explain how to use db_name
* [FIX] web_environment_ribbon: Fix to show the ribbon to every non-admin user * [FIX] web_environment_ribbon: Version number
Currently translated at 100,0% (4 of 4 strings) Translation: web-11.0/web-11.0-web_environment_ribbon Translate-URL: https://translation.odoo-community.org/projects/web-11-0/web-11-0-web_environment_ribbon/pt_BR/
[MIG] web_environment_ribbon: Migration to 12.0 [FIX] Default value for ribbon.name if not exists [FIX] Hide ribbon when ribbon.name is false or not existing [FIX] Remove copyright flag on __init__ files [REM] Debugging logs [REM] Make quotes inconsistant again and change sequence of data files in manifest
[UPD] Update web_environment_ribbon.pot Update translation files Updated by Update PO files to match POT (msgmerge) hook in Weblate. [UPD] README.rst
Currently translated at 100.0% (4 of 4 strings) Translation: web-12.0/web-12.0-web_environment_ribbon Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_environment_ribbon/es/
Currently translated at 75.0% (3 of 4 strings) Translation: web-12.0/web-12.0-web_environment_ribbon Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_environment_ribbon/pt/
Currently translated at 100.0% (3 of 3 strings) Translation: web-19.0/web-19.0-web_environment_ribbon Translate-URL: https://translation.odoo-community.org/projects/web-19-0/web-19-0-web_environment_ribbon/sv/
Currently translated at 100.0% (3 of 3 strings) Translation: web-19.0/web-19.0-web_environment_ribbon Translate-URL: https://translation.odoo-community.org/projects/web-19-0/web-19-0-web_environment_ribbon/da/
Currently translated at 100.0% (1 of 1 strings) Translation: web-19.0/web-19.0-web_environment_ribbon Translate-URL: https://translation.odoo-community.org/projects/web-19-0/web-19-0-web_environment_ribbon/sl/
OCA-git-bot
added
mod:web_environment_ribbon
|
I'm getting this error when using the module in a project: error_service.js:100 Error: Component "WebEnvironmentRibbon" defines a static "props" or "defaultProps", which Owl 3 ignores. Declare the props schema through "useProps" instead, e.g. "props = useProps({ someProp: t.string().optional(defaultValue) })". |
|
/ocabot migration web_environment_ribbon |
089a466 to
18494af
Compare
|
@rven thanks for the report! Fixed: removed the static |
rven
left a comment
rven
left a comment
There was a problem hiding this comment.
LGTM! Also functionally tested.
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
Code and functional review
/ocabot merge nobump
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 30a172a. Thanks a lot for contributing to OCA. ❤️ |
20 participants
Migration of
web_environment_ribbonto 20.0.Changes beyond the standard migration steps:
ir.config_parameter.get_param/set_paramwere removed in 20.0 (odoo/odoo@a4f2879). Replaced withget_str/set_strin the backend model and in the test.get_strreturns''instead ofFalse. The JS component already treats both as empty, so the ribbon stays hidden as before._prepare_ribbon_nameand comparing againstFalseshould be checked when they are migrated.Tested on a fresh 20.0 database with demo data: the module installs, its test passes, and the ribbon shows the configured name and colors.