[19.0][MIG] web_widget_dropdown_dynamic: Migration to 19.0 by idris-domatix · Pull Request #3617 · OCA/web

idris-domatix · 2026-07-22T09:09:59Z

Migration of `web_widget_dropdown_dynamic` to 19.0

Standard migration. Module history ported from 18.0.

Migration changes:

Manifest version bumped to 19.0.1.0.0.
JS widget adapted to the 19.0 web framework (field_dynamic_dropdown.esm.js): the field renders as .o_select_menu (OWL), no OwlError.
models/ir_filters.py adjusted for 19.0.

Validation (local, without demo, mirroring CI):

pre-commit green (0 errors).
Install with --test-enable --without-demo=all: clean, 0 failed, 0 error, module loads without traceback.
Browser smoke: field renders, dropdown opens options and persists the integer selection.

No Python tests in this module (only a JS QUnit suite).

[UPD] Update web_widget_dropdown_dynamic.pot [UPD] Update web_widget_dropdown_dynamic_example.pot [UPD] README.rst [ADD] icon.png [UPD] README.rst

MiquelRForgeFlow · 2026-09-03T10:11:51Z

+                 El ancla y el contexto se actualizan en consecuencia; ahora
+                 depending_on llega como lista de ids. -->


could you do in english everywhere? In fact, you should delete migration comments, as they are not useful once PR is merged.

idris-domatix · 2026-09-03T10:58:25Z

Will switch the remaining comments to English and drop the migration comments in the next push.

idris-domatix · 2026-09-04T07:03:58Z

Done: comments in the module are now in English and the migration comments have been dropped.

Andrii9090-tecnativa

I tested it on runboat, and it works.
Can you squash the commits? https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

@Tecnativa TT64152

Andrii9090-tecnativa · 2026-09-09T15:36:00Z

+
+        await editInput(target, ".o_field_widget[name='change_field'] input", "step-1");
+        assert.containsN(target, "option", 2);
+        assert.containsOnce(target, "option[value='\"value\"']");


Can you review this test? In v19, the elements option no longer exists, and SelectMenu is rendered differently.

idris-domatix · 2026-09-10T07:45:34Z

Thanks for the review.

Commits squashed: the branch is now a single commit [19.0][MIG] web_widget_dropdown_dynamic: Migration to 19.0, rebased on top of the latest 19.0 (the bot/Weblate commits are gone).
JS test reviewed: the test was still written for the v18 QUnit helpers and relied on <option> elements, which no longer exist in v19. I migrated it to Hoot (web.assets_unit_tests) and updated it to the v19 SelectMenu DOM (.o_select_menu_item), following the core selection_field tests.

Verified locally on 19.0: 4/4 Hoot tests and 4/4 Python tests pass.

Andrii9090-tecnativa · 2026-09-10T12:22:33Z

Thanks for the review.

Commits squashed: the branch is now a single commit [19.0][MIG] web_widget_dropdown_dynamic: Migration to 19.0, rebased on top of the latest 19.0 (the bot/Weblate commits are gone).

JS test reviewed: the test was still written for the v18 QUnit helpers and relied on <option> elements, which no longer exist in v19. I migrated it to Hoot (web.assets_unit_tests) and updated it to the v19 SelectMenu DOM (.o_select_menu_item), following the core selection_field tests.

Verified locally on 19.0: 4/4 Hoot tests and 4/4 Python tests pass.

You need to squash the administrative commits. Otherwise, we will lose the entire commit history.
https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

pedrobaeza · 2026-09-10T13:42:45Z

Yes, you have to squash some commits (administrative and translations one if proceed), not everyone.

Currently translated at 100.0% (3 of 3 strings) Translation: web-17.0/web-17.0-web_widget_dropdown_dynamic Translate-URL: https://translation.odoo-community.org/projects/web-17-0/web-17-0-web_widget_dropdown_dynamic/it/

Change the License to LGPL-3 in order to be able to use this module with other modules with non-AGPL-3 licenses. Task:4743

Currently translated at 100.0% (3 of 3 strings) Translation: web-18.0/web-18.0-web_widget_dropdown_dynamic Translate-URL: https://translation.odoo-community.org/projects/web-18-0/web-18-0-web_widget_dropdown_dynamic/es/

idris-domatix · 2026-09-10T17:30:32Z

Thanks @Andrii9090-tecnativa and @pedrobaeza. I had squashed everything into a single commit, which was wrong.

I have restored the module commit history and rebased to fixup only the administrative commits:

[BOT] post-merge updates, [UPD] Update *.pot and Update translation files are now squashed into the contributor commit that generated them.
Weblate translation commits from the same author and language have been merged together.
The contributor commits ([ADD], [MIG] 13.0 → 19.0, [IMP]...) are preserved, and the [19.0][MIG] commit now also includes the JS test migration to Hoot.

The module content is unchanged (4/4 Hoot tests and 4/4 Python tests pass).

pedrobaeza · 2026-09-11T06:00:04Z

/ocabot migration web_widget_dropdown_dynamic

Andrii9090-tecnativa · 2026-09-15T08:43:26Z

@idris-domatix can you check the tests?

Andrii9090-tecnativa · 2026-09-16T15:56:13Z

@idris-domatix can you repeat please?

idris-domatix · 2026-10-07T07:23:45Z

Thanks for the review.

Removed the migration comments; the module now keeps only the code.
Migration commit subject fixed to [MIG] web_widget_dropdown_dynamic: Migration to 19.0.
The tests were already rewritten for the v19 SelectMenu (they now use .o_select_menu_item).
The previous CI failures were infrastructure-only ("The job was not started because it repeatedly failed to be acquired"), so this run should be green.

About the squash request: there are no bot [UPD] commits in the diff. The only same-author/same-language Weblate duplicate (Italian, mymage) is separated by the [MIG] ... 17.0 commit, which also edits it.po, so merging them would conflict; per the wiki those are left as is.

@MiquelRForgeFlow @Andrii9090-tecnativa could you take another look when you have a moment?

OCA-git-bot · 2026-10-07T09:15:37Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza · 2026-10-07T10:40:13Z

/ocabot merge nobump

OCA-git-bot · 2026-10-07T10:40:24Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 19.0-ocabot-merge-pr-3617-by-pedrobaeza-bump-nobump, awaiting test results.

alexey-pelykh added 4 commits July 22, 2026 11:02

[ADD] web_widget_dropdown_dynamic

0295134

[UPD] Update web_widget_dropdown_dynamic.pot [UPD] Update web_widget_dropdown_dynamic_example.pot [UPD] README.rst [ADD] icon.png [UPD] README.rst

[IMP] web_widget_dropdown_dynamic: black, isort, prettier

9ba5d2b

[MIG] web_widget_dropdown_dynamic: Migration to 13.0

d547858

[UPD] Brainbean Apps => CorporateHub

fb45fca

OCA-git-bot added mod:web_widget_dropdown_dynamic Module web_widget_dropdown_dynamic series:19.0 labels Jul 22, 2026

MiquelRForgeFlow suggested changes Sep 3, 2026

View reviewed changes

idris-domatix force-pushed the 19.0-mig-web_widget_dropdown_dynamic branch from b3f6e80 to 9d1acfb Compare September 4, 2026 07:03

idris-domatix force-pushed the 19.0-mig-web_widget_dropdown_dynamic branch from 9d1acfb to 517bcc5 Compare September 4, 2026 07:24

Andrii9090-tecnativa suggested changes Sep 9, 2026

View reviewed changes

idris-domatix force-pushed the 19.0-mig-web_widget_dropdown_dynamic branch from 517bcc5 to c820d87 Compare September 10, 2026 07:45

claudiagn and others added 14 commits September 10, 2026 19:29

Added translation using Weblate (Spanish)

ad8f608

[IMP] web_widget_dropdown_dynamic: black, isort, prettier

f258caa

[MIG] web_widget_dropdown_dynamic: Migration to 14.0

95399a1

Added translation using Weblate (German)

e17fd42

[IMP] web_widget_dropdown_dynamic: black, isort, prettier

76e0a1f

[MIG] web_widget_dropdown_dynamic: Migration to 15.0

a3a2b8d

[16.0][MIG] web_widget_dropdown_dynamic

2c88ebd

[16.0][MIG]web_widget_dropdown_dynamic: Migrate to version 16.0

1cc9489

Added translation using Weblate (Italian)

4c9fb07

[IMP] web_widget_dropdown_dynamic: pre-commit auto fixes

054905c

[MIG] web_widget_dropdown_dynamic: Migration to 17.0

76f9527

Translated using Weblate (Italian)

df489f2

Currently translated at 100.0% (3 of 3 strings) Translation: web-17.0/web-17.0-web_widget_dropdown_dynamic Translate-URL: https://translation.odoo-community.org/projects/web-17-0/web-17-0-web_widget_dropdown_dynamic/it/

[MIG] web_widget_dropdown_dynamic: Migration to 18.0

6ae5c31

[IMP] web_widget_dropdown_dynamic: Remove QUnit import from tests

a47b0d9

Mikhail Lapin and others added 4 commits September 10, 2026 19:29

[IMP] web_widget_dropdown_dynamic: license change

5eed219

Change the License to LGPL-3 in order to be able to use this module with other modules with non-AGPL-3 licenses. Task:4743

Added translation using Weblate (Turkish)

4305cba

Translated using Weblate (Spanish)

d47000a

Currently translated at 100.0% (3 of 3 strings) Translation: web-18.0/web-18.0-web_widget_dropdown_dynamic Translate-URL: https://translation.odoo-community.org/projects/web-18-0/web-18-0-web_widget_dropdown_dynamic/es/

Added translation using Weblate (Slovenian)

1574e68

idris-domatix force-pushed the 19.0-mig-web_widget_dropdown_dynamic branch from c820d87 to 784fe15 Compare September 10, 2026 17:30

OCA-git-bot added this to the 19.0 milestone Sep 11, 2026

OCA-git-bot mentioned this pull request Sep 11, 2026

Migration to version 19.0 #3295

Open

28 of 46 tasks

idris-domatix force-pushed the 19.0-mig-web_widget_dropdown_dynamic branch from 784fe15 to 6097035 Compare September 15, 2026 09:26

[MIG] web_widget_dropdown_dynamic: Migration to 19.0

bae84e7

idris-domatix force-pushed the 19.0-mig-web_widget_dropdown_dynamic branch from 6097035 to bae84e7 Compare October 7, 2026 07:23

Andrii9090-tecnativa approved these changes Oct 7, 2026

View reviewed changes

MiquelRForgeFlow approved these changes Oct 7, 2026

View reviewed changes

OCA-git-bot added approved ready to merge labels Oct 7, 2026

OCA-git-bot added the bot is merging ⏳ label Oct 7, 2026

		El ancla y el contexto se actualizan en consecuencia; ahora
		depending_on llega como lista de ids. -->

Conversation

idris-domatix commented Jul 22, 2026

Migration of web_widget_dropdown_dynamic to 19.0

Uh oh!

MiquelRForgeFlow Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

idris-domatix commented Sep 3, 2026

Uh oh!

idris-domatix commented Sep 4, 2026

Uh oh!

Andrii9090-tecnativa left a comment

Choose a reason for hiding this comment

Uh oh!

Andrii9090-tecnativa Sep 9, 2026

Choose a reason for hiding this comment

Uh oh!

idris-domatix commented Sep 10, 2026

Uh oh!

Andrii9090-tecnativa commented Sep 10, 2026

Uh oh!

pedrobaeza commented Sep 10, 2026

Uh oh!

idris-domatix commented Sep 10, 2026

Uh oh!

pedrobaeza commented Sep 11, 2026

Uh oh!

Andrii9090-tecnativa commented Sep 15, 2026

Uh oh!

Andrii9090-tecnativa commented Sep 16, 2026

Uh oh!

idris-domatix commented Oct 7, 2026

Uh oh!

OCA-git-bot commented Oct 7, 2026

Uh oh!

pedrobaeza commented Oct 7, 2026

Uh oh!

OCA-git-bot commented Oct 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

Migration of `web_widget_dropdown_dynamic` to 19.0