Repository navigation
[20.0][MIG]: base_location - #2478
Open
Alexgars73 wants to merge 99 commits into
Open
Alexgars73 wants to merge 99 commits into
Alexgars73 wants to merge 99 commits into
Conversation
… when company country is filled.
…ssues with module partner_address_street3
…some views. Added two columns in respective tree views.
…ooks * Added Icon. * Improve module description and extracted to README.rst. * Pass country instead of country_id for advance comparisons. * Allow to transform city name. * Some code style. * Do not remove all entries of a country, but only not found. * Include hooks for transforming some things. * Include spanish translation.
Brussels Belgium city
…y, state and country in order to allow search using '%' from the m2o widget
* Headers shortened * Move cities management to settings
* [IMP] base_location: Add lat & long to `better.zip` * Add latitude and longitude columns to `better.zip` * [IMP] base_location_geonames_import: Add lat/long * Add support for latitude & longitude to genomes importer
Incredibly not included in Odoo core.
Currently translated at 66.7% (24 of 36 strings) Translation: partner-contact-11.0/partner-contact-11.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-11-0/partner-contact-11-0-base_location/es/
Currently translated at 100,0% (36 of 36 strings) Translation: partner-contact-11.0/partner-contact-11.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-11-0/partner-contact-11-0-base_location/de/
This module has now been refactored to be more consistent with what base_address_city offers to the location management. Added dependency to contacts so that I could change the menu location for cities / zip management. Now, every res.city record has a relation One2many to res.city.zip (old res.better.zip). This way, every zip has a realted city too. Zips can be searched through city code, zip or city name (same as before). Modified tests and deleted not needed tests. Added sql contraints so that zips and cities are unique within it's country / state / city.
Steps: - Open company form - Set 'city completion' field Get 'The state of the partner My Company differs from that in location X' Disabling _check_zip while writing 'zip' fields from company, as incompatible with the sequence of write operations. Automatic test is added too.
Currently translated at 57.6% (19 of 33 strings) Translation: partner-contact-12.0/partner-contact-12.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-base_location/es/
* Don't need cities for migrating Previous script required to have cities populated for working, but that's not usual thing, as people in v11 may choose to not import them, and for older databases they even weren't that option. With this improve script, now we populate city table for ZIP entries without city, so the rest of the queries are properly executed in any case. * Cover case of res_better_zip w/o country_id * Avoid error on null zip numbers
* Standard procedure * Change v13 specifics * Adapt tests + correct some practices
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-18.0/partner-contact-18.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-18-0/partner-contact-18-0-base_location/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-19.0/partner-contact-19.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-19-0/partner-contact-19-0-base_location/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-19.0/partner-contact-19.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-19-0/partner-contact-19-0-base_location/
Currently translated at 100.0% (33 of 33 strings) Translation: partner-contact-19.0/partner-contact-19.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-19-0/partner-contact-19-0-base_location/it/
Contributor
|
This PR has the |
Member
|
/ocabot migration base_location |
StefanRijnhart
requested changes
Oct 6, 2026
| for record in self.filtered("zip_id"): | ||
| for record in self: | ||
| if not record.zip_id: | ||
| continue |
Member
There was a problem hiding this comment.
Why are there all these meaningless changes? This one seems to undo a well known Odoo pattern, and others are a matter of opinion. It's mainly noise at this point. And if your coding agent did that arbitrarily, can you disclose? See https://github.com/OCA/.github/blob/master/AI_POLICY.md
Assisted-by: OpenAI Codex
Alexgars73
force-pushed
the
20.0-mig-base_location
branch
from
October 6, 2026 13:36
cede918 to
ff6a0fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard migration to v20.
Assisted-by: OpenAI Codex