Skip to content

[19.0][MIG] partner_address_format_domestic: Migration to 19.0 - #2345

Open
AungKoKoLin1997 wants to merge 7 commits into
OCA:19.0from
qrtl:19.0-mig-partner_address_format_domestic
Open

[19.0][MIG] partner_address_format_domestic: Migration to 19.0#2345
AungKoKoLin1997 wants to merge 7 commits into
OCA:19.0from
qrtl:19.0-mig-partner_address_format_domestic

Conversation

@AungKoKoLin1997

@AungKoKoLin1997 AungKoKoLin1997 commented May 14, 2026

Copy link
Copy Markdown
Contributor

@qrtl QT6658

@OCA-git-bot OCA-git-bot added series:19.0 mod:partner_address_format_domestic Module partner_address_format_domestic labels May 14, 2026
luisDIXMIT
luisDIXMIT reviewed May 14, 2026
View reviewed changes

@luisDIXMIT luisDIXMIT left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and tested locally because runboat is broken, LGTM justo one minor question

Comment thread partner_address_format_domestic/models/res_country.py Outdated
luisDIXMIT
luisDIXMIT approved these changes May 14, 2026
View reviewed changes

@luisDIXMIT luisDIXMIT left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

yostashiro
yostashiro suggested changes May 17, 2026
View reviewed changes
Comment thread partner_address_format_domestic/tests/test_partner_address_format_domestic.py Outdated
Comment thread partner_address_format_domestic/models/res_country.py
@AungKoKoLin1997
AungKoKoLin1997 force-pushed the 19.0-mig-partner_address_format_domestic branch from 156436a to 690b636 Compare May 18, 2026 02:10
@AungKoKoLin1997
AungKoKoLin1997 marked this pull request as draft May 19, 2026 01:16
@AungKoKoLin1997
AungKoKoLin1997 marked this pull request as ready for review May 19, 2026 01:19
BhaveshHeliconia
BhaveshHeliconia approved these changes May 19, 2026
View reviewed changes

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM!

yostashiro
yostashiro approved these changes May 19, 2026
View reviewed changes

@yostashiro yostashiro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. LTGM.

nobuQuartile
nobuQuartile reviewed May 28, 2026
View reviewed changes
Comment thread partner_address_format_domestic/tests/test_partner_address_format_domestic.py
Comment thread partner_address_format_domestic/models/res_country.py Outdated
@AungKoKoLin1997
AungKoKoLin1997 force-pushed the 19.0-mig-partner_address_format_domestic branch from 690b636 to e47ee07 Compare May 28, 2026 07:19
nobuQuartile
nobuQuartile approved these changes May 28, 2026
View reviewed changes

@nobuQuartile nobuQuartile left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Code review and functional review

@github-actions

github-actions Bot commented Sep 27, 2026

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 27, 2026
@AungKoKoLin1997
AungKoKoLin1997 force-pushed the 19.0-mig-partner_address_format_domestic branch from e47ee07 to 28e61b0 Compare September 28, 2026 01:20
@yostashiro

yostashiro commented Sep 28, 2026

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Sorry @yostashiro you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@AungKoKoLin1997
AungKoKoLin1997 force-pushed the 19.0-mig-partner_address_format_domestic branch from 28e61b0 to 085a00c Compare October 5, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers
@yostashiro yostashiro yostashiro approved these changes
@luisDIXMIT luisDIXMIT luisDIXMIT approved these changes
@nobuQuartile nobuQuartile nobuQuartile approved these changes
@BhaveshHeliconia BhaveshHeliconia BhaveshHeliconia approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved mod:partner_address_format_domestic Module partner_address_format_domestic series:19.0 stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@AungKoKoLin1997 @yostashiro @OCA-git-bot @luisDIXMIT @nobuQuartile @BhaveshHeliconia @mymage