[FIX] edi_core_oca: use savepoint to prevent state corruption on errors

[guewen]

Some errors such as

  ValueError,
  FileNotFoundError,
  exceptions.UserError,
  exceptions.ValidationError,

are caught, never re-raised, and the transaction is finally committed.

Which means a UserError/ValidationError gets committed, leading to corruption of the processed data.

[OCA-git-bot]

Hi @simahawk, @etobella,
some modules you are maintaining are being modified, check this out!

[guewen]

Hi @etobella @simahawk, can you have a look please? This one can lead to nasty data corruption, for e.g. in our case quants quantities were modified when they should have been rolled back

[simahawk]

Good catch! Thank you!

[simahawk]

CI is red due to

  File "/__w/edi-framework/edi-framework/edi_core_oca/models/edi_exchange_record.py", line 170, in _compute_exchange_filename
    rec.exchange_filename = rec.type_id._make_exchange_filename(rec)
  File "/__w/edi-framework/edi-framework/edi_core_oca/models/edi_exchange_type.py", line 317, in _make_exchange_filename
    return pattern.format(
  File "/opt/odoo/odoo/_monkeypatches/_cpython.py", line 85, in format
    return origin_format(*args, **kwargs)
AttributeError: 'edi.exchange.consumer.test' object has no attribute 'ref'

That's because exchange_filename_pattern is set to use ref but the test model does not have it.
Weird it didn't fail before. Can you check that? (I would simply add a ref field to the test model)

[guewen]

oops, I did actually fix the CI issue by changing the file pattern some time ago, but overwritten it today when rebasing 🤦 ☕

[guewen]

Pushed your simpler proposition of adding a ref field

[simahawk]

/ocabot merge patch

Would you mind porting to v19? 🙏

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-284-by-simahawk-bump-patch, awaiting test results.

[etobella]

Makes sense to me

[OCA-git-bot]

Congratulations, your PR was merged at 11e4312. Thanks a lot for contributing to OCA. ❤️

[guewen]

Would you mind porting to v19? 🙏

Yep, done here: #316