Read connection pool test plan - #103
Merged
Merged
Conversation
Co-authored-by: pierre <pierre@bazoge.com>
|
Cursor Agent can help with this pull request. Just |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #103 +/- ##
==========================================
+ Coverage 81.37% 81.39% +0.02%
==========================================
Files 151 151
Lines 28276 28276
==========================================
+ Hits 23010 23016 +6
+ Misses 4173 4168 -5
+ Partials 1093 1092 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: pierre <pierre@bazoge.com>
Co-authored-by: pierre <pierre@bazoge.com>
Co-authored-by: pierre <pierre@bazoge.com>
Co-authored-by: pierre <pierre@bazoge.com>
Co-authored-by: pierre <pierre@bazoge.com>
Co-authored-by: pierre <pierre@bazoge.com>
Co-authored-by: pierre <pierre@bazoge.com>
Add a markdown file documenting test commands and update the Makefile to include connection pool tests in the agent test command. Co-authored-by: pierre <pierre@bazoge.com>
Co-authored-by: pierre <pierre@bazoge.com>
Co-authored-by: pierre <pierre@bazoge.com>
Co-authored-by: pierre <pierre@bazoge.com>
pierre-b
marked this pull request as ready for review
October 30, 2025 09:48
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| err := <-done | ||
| if err != nil && err.Error() == "panic" { | ||
| panicCount++ | ||
| } |
There was a problem hiding this comment.
Bug: Panic Detection Fails Due to String Comparison
The test's panic detection is ineffective because the error message created (e.g., "panic: ") is compared using an exact match against the literal string "panic". This mismatch prevents panicCount from incrementing, causing panics to go undetected.
pull Bot
pushed a commit
to bhardwajRahul/notifuse
that referenced
this pull request
Feb 22, 2026
* feat: Add comprehensive connection pool testing infrastructure Co-authored-by: pierre <pierre@bazoge.com> * Checkpoint before follow-up message Co-authored-by: pierre <pierre@bazoge.com> * Refactor connection pool tests and add status documentation Co-authored-by: pierre <pierre@bazoge.com> * feat: Increase postgres max_connections for integration tests Co-authored-by: pierre <pierre@bazoge.com> * Checkpoint before follow-up message Co-authored-by: pierre <pierre@bazoge.com> * Fix: Add delays and timeouts to connection pool tests Co-authored-by: pierre <pierre@bazoge.com> * Checkpoint before follow-up message Co-authored-by: pierre <pierre@bazoge.com> * Test: Use assert.Same for pool instance checks Co-authored-by: pierre <pierre@bazoge.com> * Refactor: Add test documentation and update Makefile Add a markdown file documenting test commands and update the Makefile to include connection pool tests in the agent test command. Co-authored-by: pierre <pierre@bazoge.com> * Refactor: Rename test-agent to e2e-test-within-cursor-agent Co-authored-by: pierre <pierre@bazoge.com> * Refactor e2e-test-within-cursor-agent to run only integration tests Co-authored-by: pierre <pierre@bazoge.com> * Refactor: Simplify and unify integration test commands Co-authored-by: pierre <pierre@bazoge.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No PR was created as no code changes were made during this session. The user's request was to read a plan, which the assistant fulfilled by summarizing the plan.