perl540: fix cross compilation#418640
Merged
Merged
Conversation
uninsane
added
the
6.topic: cross-compilation
github-actions
Bot
added
10.rebuild-darwin: 0
13 tasks
misuzu
approved these changes
Jun 21, 2025
misuzu
left a comment
misuzu
left a comment
Contributor
There was a problem hiding this comment.
Tested by building on x86_64-linux
- pkgsCross.riscv64.perl
github-actions
Bot
added
the
12.approvals: 1
alyssais
previously requested changes
Jun 21, 2025
This comment was marked as outdated.
This comment was marked as outdated.
uninsane
force-pushed
the
pr-perl540-cross
branch
from
145eab4 to
08ec491
Compare
Contributor
Author
|
@alyssais I've vendored the patch now. thanks for teaching me about the forge gc pitfalls. |
marcin-serwin
approved these changes
Jun 21, 2025
github-actions
Bot
added
12.approvals: 2
Member
|
@ofborg build pkgsCross.riscv64.perl540 |
Contributor
|
Successfully created backport PR for |
1 task
github-actions
Bot
added
the
8.has: port to stable
Artturin
reviewed
Aug 17, 2025
Comment on lines
+329
to
+333
| patches = [ | ||
| # fixes build failure due to missing d_fdopendir/HAS_FDOPENDIR configure option | ||
| # https://github.com/arsv/perl-cross/pull/159 | ||
| ./cross-fdopendir.patch | ||
| ]; |
Member
There was a problem hiding this comment.
This overrides the patches above
, which breaks, for example,ModuleBuild.:P
Making a PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nix-build -A pkgsCross.aarch64-multiplatform.perl540cc: @rhelmot as this PR cherry-picks the patch you sent upstream.
tested by deploying a cross system & confirming the
xdg-utilsbinaries (which use perl) still work.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.