Skip to content

Android: divider defaults to the theme outline colour - #94

Open
sandermj wants to merge 1 commit into
NativePHP:mainfrom
sandermj:fix/android-divider-colour
Open

sandermj wants to merge 1 commit into
NativePHP:mainfrom
sandermj:fix/android-divider-colour

Conversation

@sandermj

Copy link
Copy Markdown

Fixes #93.

SimpleRenderers.kt DividerRenderer: when no border colour is authored, use NativeUITheme.{dark,light}.outlineVariant instead of the hard-coded #E0E0E0, matching how the chip, checkbox and button-group renderers fall back to the theme.

Testing. Dividers on a dark Android surface are subtle instead of white; an authored border colour still applies.

Compatibility. Only the unset case changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android: divider paints a hard-coded light grey instead of the theme's outline colour

1 participant