Repository navigation
Clarify streaming mode overrides and saved playback FPS - #589
Closed
stayinalive181 wants to merge 1 commit into
Closed
stayinalive181 wants to merge 1 commit into
stayinalive181 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifies two inference CLI details in
docs/sana_streaming.md:--moderetains its explicit checkpoint, config and sampling arguments; the gallery note now explains how to switch safely.--fpsis passed to the saved MP4 writer. It controls playback timing, not generation throughput. The docs now distinguish it from measured inference/deployment FPS.Both statements were traced to the current
parse_args()defaults andsave_video(..., args.fps)ininference_video_scripts/v2v/inference_sana_streaming.py. No inference behavior or defaults change.Affiliation: I work on Windflow and integrate SANA-Streaming. This is a documentation correction based on source inspection; it adds no product links or new performance claims. No tests, builds or GPU inference were run for this documentation-only change.