Repository navigation
fix(video): recognize padded filenames when resuming inference - #578
Merged
lawrence-cj merged 1 commit intoNov 12, 2026
Merged
Conversation
lawrence-cj
approved these changes
Nov 12, 2026
lawrence-cj
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @yuhengcai1, LGTM. The resume check now matches the writer's :03d filename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Video inference writes names such as
000. first-key.mp4, but its resume check looks for0. first-key.mp4. Re-running the same job therefore regenerates and overwrites outputs for indices 0–99. Use the same three-digit minimum width in the existing-file check as in the writer.The regression test generates an output, runs the same request again, and checks that text encoding, model execution, and video writing are skipped and that file bytes/mtime are unchanged. It then changes the key at the same index and verifies a new output is generated. Indices 0, 9, 99, and 100 cover the padding boundary.
Validation on CPU with PyTorch 2.9.1 (the repository pin): before 3 failed / 1 passed; after 4 passed. The same results hold with PyTorch 2.5.1. All applicable repository-pinned Python pre-commit hooks and
git diff --checkpass.The local validation harness executes the complete, unchanged
visualizefunction body with real temporary files; text/model/sampler/VAE/codec use test doubles. It isolates unrelated package imports and does not load model weights or run GPU inference. The committed regression test uses normal project imports. Batch resume policy and output filenames are otherwise unchanged.