Repository navigation
fix(video): support chunk flow Euler in video inference - #576
Merged
lawrence-cj merged 1 commit intoNov 12, 2026
Merged
Conversation
lawrence-cj
approved these changes
Nov 12, 2026
lawrence-cj
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @yuhengcai1, LGTM. This matches the WM entry point's ChunkFlowEuler wiring and fixes #355.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chunk video configuration selects
chunk_flow_euler, but the generic video inference entry point has no branch for it and raisesValueError: chunk_flow_euler is not defined. This connects the existingChunkFlowEulersampler to that entry point, derives the chunk boundaries from the configuration, and uses the same automatic interval convention as the WM entry point. A missing chunk configuration now produces an actionable error.The regression test exercises the complete
visualizebody with the real sampler and a constant-velocity model. It checks CFG on/off, automatic/explicit intervals, prefix lengths and per-frame timesteps, the integrated latent result, and the missing-configuration error on CPU and CUDA. Text encoding, VAE decoding, and video writing are replaced with small test doubles; no pretrained weights are needed.Validation against main
b3bad9563288b5fd0dc5734fc230827acf70f23e:git diff --checkpass.Validation scope: the standalone runner loads the unchanged complete
visualizeand sampler class definitions from the exact source files while isolating unrelated module imports. It executes the submitted test functions against the real PyTorch/Diffusers scheduler; it does not validate the full Sana import/dependency setup, CLI, or pretrained video quality. Source hashes and JUnit results were captured. The committed test uses normal project imports for the supported Sana environment.Fixes #355.