Fix KernelCh completion ordering in profiler proxy#2221
Open
usernamehaha2022 wants to merge 1 commit into
Open
Fix KernelCh completion ordering in profiler proxy#2221usernamehaha2022 wants to merge 1 commit into
usernamehaha2022 wants to merge 1 commit into
Conversation
Collaborator
|
++ @armratner @rishdas to take a look |
Collaborator
|
This no longer will be relevant, as we decouple from the proxy in 2.31, and we covered this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a race in the NCCL profiler proxy where a KernelCh completion event could be processed before the corresponding start event was delivered.
The proxy now only stops/drains a KernelCh profiler sub-operation after StartKernelChEvent has been posted.
In stress testing with many small Ring+LL collectives, inspector logs showed missing coll_sn records across ranks, indicating dropped profiler records caused by this ordering race. Example gaps included:
Related Issues
N/A
Changes & Impact
Performance Impact
No expected impact on normal NCCL collective performance.
The change is limited to the profiler proxy path and only adds one CPU-side condition when profiler/inspector is enabled.