Fix rma proxy connect cleanup#2205
Open
wanglei875 wants to merge 1 commit into
Open
Conversation
wanglei875
force-pushed
the
fix-rma-proxy-connect-cleanup
branch
from
edf9459 to
5a4fcb1
Compare
Signed-off-by: WangLei <1539790288@qq.com>
Collaborator
|
++ @jynv to review and mirror if it looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
Clean up partially initialized RMA proxy resources when
ncclRmaProxyConnectOnce()fails.The failure path now closes:
listen()succeededAlso routes
rmaProxyCtxsallocation through the existing failure cleanup path.Testing
git diff --check -- src/rma/rma_proxy.ccmake -j$(nproc) src.buildcompiledrma/rma_proxy.cc; full build later failed on an existing missingplugin_cleanup.hinclude inplugin/rma/rma_v13.cc.Related Issues
Changes & Impact
Performance Impact