fix(build): check for IB verbs extension(s) support#2178
Open
miEsMar wants to merge 1 commit into
Open
Conversation
Latest NCCL implementations added support for Infiniband extension features, such as `active_speed_ex` in `struct ibv_port_attr`. However, such additional support was not added in a backward compatible way. This fix adds proper configuration-time checks to make sure the Infiniband installation supports newer features and extensions, instead of blindly assuming they are supported, causing compile errors in the "net_ib" transport component. Credits: AccelCom @ Barcelona Supercomputing Center (c) Barcelona Supercomputing Center 2026
Member
|
I'm not sure I understand what problem we're solving here. Under which conditions do you see compilation errors? Can you provide the build command line and the errors in the output ? |
Author
|
If NCCL is built with Build command: make src.${_make_tgt} \
VERBOSE=1 \
TRACE=1 \
RDMA_CORE=1 \
NET_PROFILER=1 \
CC=gcc \
CXX=g++ \
PREFIX=${INSTALLDIR} \
CUDA_HOME=${NVCUDA_ROOT} \
NVCC_GENCODE=${_gpu_archs} \
-j ${_nthreads}Error: Therefore, the PR adds a check at build time that preemptively checks for actual IB extensions supports, and only includes usage if they are, otherwise falls back to base features. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Latest NCCL implementations added support for
Infiniband extension features, such as
active_speed_exinstruct ibv_port_attr. However, such additional support was not added in a backward compatible way.This fix adds proper configuration-time checks to make sure the Infiniband installation supports newer features and extensions, instead of blindly assuming they are supported,
causing compile errors in the "net_ib" transport component.
Credits: AccelCom @ Barcelona Supercomputing Center
Related Issues
N/A.
Changes & Impact
N/A.
Performance Impact
N/A.