Add upgradePolicy to NVIDIADriver CRD#2582
Open
cdesiniotis wants to merge 1 commit into
Open
Conversation
c145169 to
10fce04
Compare
tariq1890
reviewed
Jun 26, 2026
tariq1890
reviewed
Jun 26, 2026
tariq1890
reviewed
Jun 26, 2026
tariq1890
reviewed
Jun 26, 2026
tariq1890
reviewed
Jun 26, 2026
rahulait
reviewed
Jun 26, 2026
43f03c5 to
2080190
Compare
rahulait
reviewed
Jun 26, 2026
fa6df1e to
ad29e8b
Compare
tariq1890
reviewed
Jun 27, 2026
tariq1890
reviewed
Jun 27, 2026
ad29e8b to
8d2a1ea
Compare
tariq1890
reviewed
Jun 27, 2026
The upgradePolicy influences how the driver-upgrade controller upgrades GPU driver daemonsets. Adding this field to the NVIDIADriver CRD allows users to define different upgrade policies for different NVIDIADriver CRs. If nil or empty, the driver-upgrade controller will fallback to using a default upgradePolicy defined in the code which aligns with the defaults in our helm values. Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
8d2a1ea to
c4fe7d4
Compare
tariq1890
approved these changes
Jun 27, 2026
Contributor
|
LGTM. I am wondering about backward compatibility. Existing user-defined nvidiadriver CRs won't have upgrade configuration, and previously they were defaulting to the config in clusterpolicy. If custom upgrade config was used in clusterpolicy previously and user specified nvidiadriver was using it and now user upgrades to newer version, nvidiadriver will start using default config we specify. Would we be documenting this as a breaking change or something for users to be aware of when they are using nvidiadrivers and they jump to v26.7.0? |
rahulait
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upgradePolicy influences how the driver-upgrade controller upgrades GPU driver daemonsets. Adding this field to the NVIDIADriver CRD allows users to define different upgrade policies for different NVIDIADriver CRs. If nil or empty, the driver-upgrade controller will fallback to using a default upgradePolicy defined in the code which aligns with the defaults in our helm values.
Code changes in this PR were drafted with the assistance of Claude Code.
Testing
I tested the following scenarios on a k8s cluster with two GPUs:
driver.useNvidiaDriverCRD=truein ClusterPolicy; b) creating a default NVIDIADriver CR. Verify ClusterPolicy-managed pods gets orphaned then deleted by upgrade controller in a rolling fashion.spec.version. Verify upgrade controller upgrades pods in a rolling fashion.