-
Notifications
You must be signed in to change notification settings - Fork 220
Add lp format writer and rename mps references #1567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Iroy30
wants to merge
7
commits into
NVIDIA:main
Choose a base branch
from
Iroy30:add_lp_writer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f40cd59
Add LP file writer with Python bindings and C API support.
eacde95
Infer output format from path for solver problem dumps.
a1b2346
Refine LP output and unify Python write API.
34b57c4
Harden optimization problem file writing.
b4e108a
Delete .lp_harness
Iroy30 de6345d
Delete .lp_harness.cpp
Iroy30 5bb724e
Merge branch 'main' into add_lp_writer
Iroy30 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 changes: 73 additions & 0 deletions
73
cpp/include/cuopt/mathematical_optimization/io/lp_writer.hpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| /* clang-format off */ | ||
| /* | ||
| * SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
| /* clang-format on */ | ||
|
|
||
| #pragma once | ||
|
|
||
| #include <cuopt/mathematical_optimization/io/data_model_view.hpp> | ||
| #include <cuopt/mathematical_optimization/io/mps_data_model.hpp> | ||
|
|
||
| #include <memory> | ||
| #include <string> | ||
|
|
||
| namespace cuopt::mathematical_optimization::io { | ||
|
|
||
| /** | ||
| * @brief Main writer class for LP files | ||
| * | ||
| * Writes an optimization problem to a file in the LP format understood by | ||
| * read_lp(). The emitted dialect is a superset of what a typical solver | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What does superset mean here specifically? |
||
| * expects and round-trips through read_lp(): | ||
| * - Minimize / Maximize objective (with optional quadratic '[ ... ] / 2' term) | ||
| * - Subject To constraints (linear, plus optional quadratic '[ ... ]' term) | ||
| * - Bounds | ||
| * - Generals / Binaries / Semi-Continuous variable sections | ||
| * | ||
| * Notes / limitations that mirror the LP format itself: | ||
| * - Range rows (a linear row with two distinct finite bounds) are emitted as | ||
| * two constraints ('_lo' with '>=' and '_up' with '<=') because the LP | ||
| * format has no single-line ranged-row syntax. | ||
| * - The objective scaling factor is not representable in LP format and is | ||
| * therefore not written (identical to the MPS writer). | ||
| * | ||
| * @tparam i_t data type of the indices | ||
| * @tparam f_t data type of the weights and variables | ||
| */ | ||
| template <typename i_t, typename f_t> | ||
| class lp_writer_t { | ||
| public: | ||
| /** | ||
| * @brief Ctor. Takes a data model view as input and writes it out as an LP formatted file | ||
| * | ||
| * @param[in] problem Data model view to write | ||
| */ | ||
| lp_writer_t(const data_model_view_t<i_t, f_t>& problem); | ||
|
|
||
| /** | ||
| * @brief Ctor. Takes a data model as input and writes it out as an LP formatted file | ||
| * | ||
| * @param[in] problem Data model to write | ||
| */ | ||
| lp_writer_t(const mps_data_model_t<i_t, f_t>& problem); | ||
|
|
||
| /** | ||
| * @brief Writes the problem to an LP formatted file | ||
| * | ||
| * @param[in] lp_file_path Path to the LP file to write | ||
| */ | ||
| void write(const std::string& lp_file_path); | ||
|
|
||
| private: | ||
| // Owned view (created when constructing from mps_data_model_t) | ||
| std::unique_ptr<data_model_view_t<i_t, f_t>> owned_view_; | ||
| // Reference to the view (either external or owned) | ||
| const data_model_view_t<i_t, f_t>& problem_; | ||
|
|
||
| // Helper to create view from data model | ||
| static data_model_view_t<i_t, f_t> create_view(const mps_data_model_t<i_t, f_t>& model); | ||
| }; // class lp_writer_t | ||
|
|
||
| } // namespace cuopt::mathematical_optimization::io | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a class with a single method; could it be a function instead? (with overloads for data_model_view_t and mps_data_model_t)?