TST: Add remaining tests for ObjectCode.from_<library/object>#2136
Open
acosmicflamingo wants to merge 1 commit into
Open
TST: Add remaining tests for ObjectCode.from_<library/object>#2136acosmicflamingo wants to merge 1 commit into
acosmicflamingo wants to merge 1 commit into
Conversation
Contributor
e0465db to
0b4de87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #663
Unlike adding tests for
ObjectCode.from<ptx/ltoir/cubin/fatbin>, adding tests forObjectCode.from_<object/library>was not as straightforward sincecuda.core.Programmodule'sSUPPORTED_TARGETSlist do not includeObjectCodeFormatType.OBJECTorObjectCodeFormatType.LIBRARY, so doing something like this throws an exception:Going through different PRs and conversations related to testing for
ObjectCode.from_<object/library>led me to the very illuminating discussion here.Based on the very helpful back-and-forth, I took the approach of generating the library/object files within the test itself (assuming an NVCC is present in the environment, otherwise test will be skipped). Not adding a Makefile would mean we have one less file to worry about maintaining, although it does mean that the kernel is being recompiled over-and-over again when it could just be compiled once, saved, and the test relies on the persisted binaries.
I'm open to refactoring this code, whether it means creating a Makefile, generating the binaries, persisting them in the codebase, and having the tests point to them, or another approach I have not considered.