Repository navigation
Conversation
Collaborator
Author
Clean runtime validationTested commit DGX Spark / Linux arm64
Apple M4 / macOS arm64
Both fresh source checkouts remained clean at the tested SHA, both managed-install markers were present, and no PAIR/vLLM test process remained afterward. |
nvrithik
force-pushed
the
fix-vllm-launch
branch
from
November 3, 2026 08:47
75be10a to
aab7a35
Compare
6 tasks done
Let manifests declare a managed install directory and place vLLM under ~/.nvpair so FlashInfer and DeepGEMM can compile kernels without unescaped spaces. Keep the venv first on PATH for helper tools and extend reset and uninstall inventories across Linux, macOS, and Windows while preserving the Hugging Face model cache. Signed-off-by: nvrithik <rithikv@nvidia.com>
Keep the DGX Spark unified-memory guard, reserve startup headroom, and fall back to the installed vLLM platform when nvidia-smi cannot report memory. The probe covers Metal, ROCm/CUDA, XPU, CPU, and compatible out-of-tree platforms while leaving sizing to vLLM when no trustworthy reading exists. Signed-off-by: nvrithik <rithikv@nvidia.com>
Use the model dtype for a quantized KV cache when vLLM-Metal can load the checkpoint, while preserving explicit user launch options. Reject NVIDIA ModelOpt FP8 weight checkpoints before process startup with an actionable BF16, FP16, or MLX-compatible alternative because vLLM-Metal cannot load that tensor layout. Signed-off-by: nvrithik <rithikv@nvidia.com>
Exclude only nvidia/Llama-3.1-8B-Instruct-FP8 from macOS vLLM browsing and search while preserving Linux results and the shared upstream cache. Keep the existing load-time compatibility check for downloaded copies. Add regression coverage for target platforms, search, exact model matching, and cache isolation. Verify the updated app catalog on macOS and DGX Spark, with Qwen inference on Mac and FP8 inference on Spark. Signed-off-by: nvrithik <rithikv@nvidia.com>
Treat missing or impossible NVIDIA memory telemetry as unavailable and query the installed runtime. Verify integrated CUDA/ROCm and XPU hardware properties or Apple Silicon Metal support before using host memory, and remove capacity-matching and missing-value assumptions. Cover discrete devices, unknown topology, integrated devices and invalid telemetry with regression tests. Validate model loading and inference across Linux x64, DGX Spark and macOS under native-query failures and controlled memory pressure. Signed-off-by: nvrithik <rithikv@nvidia.com>
nvrithik
force-pushed
the
fix-vllm-launch
branch
from
November 12, 2026 05:54
ec49a70 to
3cd5476
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog title
More reliable vLLM setup and model loading across supported devices
Changelog body
Bumps
Description
Fix vLLM model-startup failures caused by paths containing spaces and unreliable device-memory readings.
Install PAIR-managed vLLM under
~/.nvpair/engine-bin/vllminstead of the space-containing app-data directory, and put its virtual-environment tools onPATH. Reset and uninstall remove this managed environment while preserving downloaded Hugging Face models.The location change works around upstream compiler-command quoting problems:
The workaround avoids affected installation paths while upstream fixes work their way into PAIR’s vLLM dependency.
For memory sizing, use valid NVIDIA telemetry when available and otherwise query the installed runtime. Use system RAM only after confirming shared memory, reserve an additional 3 GiB for startup on those devices, and leave the memory limit to vLLM when reliable readings are unavailable.
Validation
go test ./... -run 'Test(AutoContext|ApplyAutoLaunch|PlanToolCalling|ParsesToolCalls|DetectDeviceMemory|ParseDeviceMemoryProbe|GPUMemoryFromQuery|PlanHFContext_|PlanMetalKVCache|ValidateMetalModel|ProcessEnvironment|VenvBinDir|StartManagedProc_FindsTools|Validate_.*InstallDirectory|ApplyPlatformDefaults_|UninstallManaged_|BundledVLLMManifest|BundledModelStores_)' -count=1npx --no-install vitest run tests/modular/app-data-wipe.test.ts(
12tests passed across the configured unit and e2e projects).bash -non the three shell cleanup scripts,scripts/wipe-app-data.sh --dry-run, Python AST parsing for the embedded probe,Prettier check,
git diff --check, andnode scripts/spdx-headers.mjs.GOOS=darwin GOARCH=arm64 go build .andGOOS=windows GOARCH=amd64 go build .fromservices/nvpair-engine-manager.ownership marker under
~/.nvpair/engine-bin/vllm. With kernels enabled,nvidia/Llama-3.1-8B-Instruct-NVFP4andnvidia/Llama-3.1-8B-Instruct-FP8both reached public/internal health200and answered inference requests. Logs contained no
nvcc fatal,ninja: error, readiness exit,NotImplementedError, or OOM.forcing a BF16 KV cache passed that check but then proved the ModelOpt FP8
weights themselves are unsupported. The final manager rejected the checkpoint
in about
0.007 s, with no vLLM child or listening port. The new memory probealso reported the machine's
48 GiBunified memory and current free memory.The full repository suite was not run; validation was intentionally focused on
the three fixes and their packaging paths.
Checklist
git commit -s), certifying the Developer Certificate of Origin.services/versions.jsonis written by automation — do not edit it by hand.