Skip to content

refactor(cli): extract service settings and inference commands - #3188

Closed
varshaprasad96 wants to merge 1 commit into
NVIDIA:mainfrom
varshaprasad96:refactor/2304-extract-service-settings-inference/varshaprasad96
Closed

refactor(cli): extract service settings and inference commands#3188
varshaprasad96 wants to merge 1 commit into
NVIDIA:mainfrom
varshaprasad96:refactor/2304-extract-service-settings-inference/varshaprasad96

Conversation

@varshaprasad96

Copy link
Copy Markdown
Contributor

Summary

Extract the service, settings, and inference command implementations from the CLI run module into focused command modules. Preserve the existing run-module re-exports so command dispatch and downstream callers remain compatible.

Related Issue

Part of #2304

Changes

  • Add dedicated service, settings, and inference command modules.
  • Move existing implementations and tests to their owning modules.
  • Keep shared setting parsing tests with the common command helpers.
  • Add focused coverage for TCP forward parsing, settings JSON rendering, and inference status errors.

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests not applicable; no sandbox infrastructure, policy, or user-visible behavior changed
  • mise run test passes
  • mise run ci passes

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs not applicable; module ownership changed without an architecture or behavior change

Move service, settings, and inference command implementations out of run.rs while preserving compatibility re-exports.\n\nPart of NVIDIA#2304

Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@johntmyers

Copy link
Copy Markdown
Collaborator

not sure we need to extract inference, see #3172

@varshaprasad96

varshaprasad96 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

@johntmyers thanks for pointing this out! Just looked into the other issue, this one needs to be modified then to refactor only service settings, and remove inference. I'm going to point the agent to handle both of it in one go and modify this PR
/hold

@varshaprasad96

Copy link
Copy Markdown
Contributor Author

Closing this in favor of #3194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants