refactor(cli): extract service settings and inference commands - #3188
Closed
varshaprasad96 wants to merge 1 commit into
Closed
Conversation
Move service, settings, and inference command implementations out of run.rs while preserving compatibility re-exports.\n\nPart of NVIDIA#2304 Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
varshaprasad96
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 4, 2026 16:51
Collaborator
|
not sure we need to extract inference, see #3172 |
Contributor
Author
|
@johntmyers thanks for pointing this out! Just looked into the other issue, this one needs to be modified then to refactor only service settings, and remove inference. I'm going to point the agent to handle both of it in one go and modify this PR |
10 tasks
Contributor
Author
|
Closing this in favor of #3194 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract the service, settings, and inference command implementations from the CLI run module into focused command modules. Preserve the existing run-module re-exports so command dispatch and downstream callers remain compatible.
Related Issue
Part of #2304
Changes
Testing
Checklist