docs: fix first-network-policy sandbox lifecycle flow - #3140
Merged
johntmyers merged 1 commit intoSep 2, 2026
Conversation
russellb
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 2, 2026 18:00
The tutorial told users to exit the sandbox and reconnect later, but exiting the interactive shell stops the sandbox's main process and it is not reconnectable under the default restart policy. Switch to the two-terminal flow already used by the github-sandbox tutorial so the sandbox stays running, matching what examples/sandbox-policy-quickstart/ demo.sh actually does. Related: NVIDIA#2998, NVIDIA#2798 Signed-off-by: Russell Bryant <rbryant@redhat.com>
russellb
force-pushed
the
docs/fix-tutorial-provider-policy
branch
from
September 2, 2026 20:36
ddf4b70 to
370908f
Compare
russellb
changed the title
johntmyers
approved these changes
Sep 2, 2026
johntmyers
enabled auto-merge
September 2, 2026 20:44
Collaborator
|
/ok to test 370908f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
first-network-policytutorial, whose exit/reconnect flow fails against current behavior.Related Issue
Related to #2998 (first acceptance criterion) and #2798.
Changes
docs/get-started/tutorials/first-network-policy.mdx— The tutorial told users to exit the sandbox and reconnect later, but exiting the interactive shell stops the sandbox's main process, and it is not reconnectable under the default restart policy. Switched to the two-terminal flow already used by thegithub-sandboxtutorial so the sandbox stays running — matching whatexamples/sandbox-policy-quickstart/demo.shactually does.Notes
Scope was trimmed to just the lifecycle fix. The credential-gate parts of #2998 (the
policy set/updatefailure on provider-backed sandboxes) are the proper root-cause fix in #3129, so this PR no longer touches thegithub-sandboxtutorial or the default-policy reference. The underlying restart behavior is tracked in #2798.Testing
mise run pre-commit— passes.Checklist
docs/)