Skip to content

fix(policy): harden advisor transport proposals - #3136

Open
johntmyers wants to merge 1 commit into
mainfrom
harden-policy-advisor-tcp/jm
Open

fix(policy): harden advisor transport proposals#3136
johntmyers wants to merge 1 commit into
mainfrom
harden-policy-advisor-tcp/jm

Conversation

@johntmyers

Copy link
Copy Markdown
Collaborator

Summary

Add defense-in-depth guardrails that keep in-sandbox policy-advisor proposals on transport paths where OpenShell can enforce application authority. Agent-authored proposals may continue to omit protocol for the established explicit-proxy path, but they cannot request native transparent TCP or disable TLS inspection.

Related Issue

No public issue: localized defense-in-depth hardening for policy-advisor proposal authority.

Changes

  • Reject agent-authored protocol: tcp and tls: skip endpoints at the sandbox-local parser and gateway submission boundary
  • Preserve omitted-protocol endpoint proposals and administrator-authored native TCP policies
  • Add regression coverage for rejected raw transports and accepted explicit-proxy proposals
  • Update policy-advisor guidance and policy documentation
  • Clarify that a native TCP hostname constrains connection routing rather than application authority, including the implications of compatible shared infrastructure

Testing

  • mise run pre-commit passes
  • GIT_CONFIG_COUNT=1 GIT_CONFIG_KEY_0=tag.gpgSign GIT_CONFIG_VALUE_0=false mise run ci passes
  • Unit tests added and updated
  • E2E tests added or updated (not applicable; runtime TCP enforcement is unchanged)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

Signed-off-by: John Myers <johntmyers@users.noreply.github.com>
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant