Skip to content

feat(test-guest): allow copy mode overrides - #3091

Merged
elezar merged 1 commit into
mainfrom
codex/test-guest-copy-mode
Sep 3, 2026
Merged

feat(test-guest): allow copy mode overrides#3091
elezar merged 1 commit into
mainfrom
codex/test-guest-copy-mode

Conversation

@elezar

@elezar elezar commented Sep 1, 2026

Copy link
Copy Markdown
Member

Summary

Allow Nix test-guest --copy entries to include an optional bare permission mode suffix. When the suffix is omitted, the runner preserves the host file mode; when present, it passes the mode through to guest-side install -m.

Related Issue

No issue required: localized test VM infrastructure flag requested directly.

Changes

  • Parse --copy as SRC:DEST[:MODE].
  • Resolve the host file mode during copy validation only when MODE is omitted.
  • Reuse the resolved mode during artifact installation.
  • Update the test-guest README and runner option text.

Testing

  • bash -n nix/test-guest/run.sh
  • git diff --check
  • Focused fake-runtime parser checks for omitted mode, trailing empty mode, 755, 0755, and invalid mode deferral
  • mise run pre-commit passes, attempted via nix develop --command mise run pre-commit; timed out after 120s while building the dev environment
  • Unit tests added/updated
  • E2E tests added/updated, not run; no real VM boot exercised

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar
elezar force-pushed the codex/test-guest-copy-mode branch from eeb542c to b34f882 Compare September 3, 2026 12:51
@elezar
elezar enabled auto-merge September 3, 2026 13:14
@elezar
elezar added this pull request to the merge queue Sep 3, 2026
Merged via the queue into main with commit b8903fd Sep 3, 2026
56 checks passed
@elezar
elezar deleted the codex/test-guest-copy-mode branch September 3, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants