Fix -Wundef warning in sha2.c - #309
Merged
Merged
Conversation
When '-Wundef' is specified, compiling sha2.c would give the following
warning:
```
In file included from ./sha2.c:46:
./ldns/sha2.h:52:5: warning: ‘LDNS_BUILD_CONFIG_HAVE_INTTYPES_H’ is not defined, evaluates to ‘0’ [-Wundef]
52 | #if LDNS_BUILD_CONFIG_HAVE_INTTYPES_H
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
Fix this warning by adding the necessary <ldns/common.h> include to
sha2.c.
Meanwhile, adjust sha1.c to only include necessary headers, similar to
sha2.c.
Member
|
Yes, that looks good. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
-Wundefis specified, compiling sha2.c would give the following warning:Fix this warning by adding the necessary
<ldns/common.h>include tosha2.c.Meanwhile, adjust
sha1.cto only include necessary headers, similar tosha2.c.