Skip to content

fix: Standardize normalize output figures across MOSuite function calls#4

Merged
kelly-sovacool merged 20 commits into
mainfrom
FigOutSync
Jul 8, 2026
Merged

fix: Standardize normalize output figures across MOSuite function calls#4
kelly-sovacool merged 20 commits into
mainfrom
FigOutSync

Conversation

@phoman14

@phoman14 phoman14 commented Jul 2, 2026

Copy link
Copy Markdown
Member

Summary

This PR aligns the normalize-counts capsule with the package-level figure standardization work. The intent is for figures produced from this capsule to match figures produced by the corresponding MOSuite function calls, rather than carrying capsule-specific color or legend defaults.

Changes

  • Install MOSuite from CCBR/MOSuite@FigOutSync during capsule setup so the capsule can use the updated package behavior before the next release image is available.
  • Keep the capsule work on the FigOutSync branch; this PR does not target or update main directly.
  • Align the normalize-counts Code Ocean panel and CLI plot color defaults with the MOSuite package defaults.
  • Leave the histogram legend font size blank by default so normalize_counts() can use the package's automatic legend text scaling for many or long labels.
  • Parse an explicit histogram legend font size only when the user provides one.
  • Keep the capsule parameter descriptions focused on the user-facing defaults.
  • Update CHANGELOG.md for the user-facing default changes.
  • Add @phoman14 attribution to the development changelog entries for this PR.

Validation: local capsule tests passed (PASS 12).

Issues

No linked issue.

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • Run the capsule in Code Ocean and ensure it completes successfully with no errors. Local capsule tests passed.
  • Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Follow the style described in https://style.tidyverse.org/news.html
  • The tests workflow succeeds on the latest commit.

@phoman14 phoman14 changed the title Align normalize plot defaults with MOSuite package Standardize normalize output figures across MOSuite function calls Jul 2, 2026
@phoman14 phoman14 requested a review from kelly-sovacool July 2, 2026 20:00

@kelly-sovacool kelly-sovacool left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the merge conflicts

in the future, make sure you do the following steps before creating a new branch:

git switch main
git pull
git switch -c newbranchname

this will ensure the new branch will have the latest commits from main, and should avoid conflicts like these.
alternatively, you can use the github web interface to create a new branch for the same effect.

@phoman14 phoman14 requested a review from kelly-sovacool July 8, 2026 17:21
Comment thread environment/postInstall Outdated
@kelly-sovacool kelly-sovacool changed the title Standardize normalize output figures across MOSuite function calls fix: Standardize normalize output figures across MOSuite function calls Jul 8, 2026
@kelly-sovacool

Copy link
Copy Markdown
Member

#5 will update this branch to manage MOSuite via syncweaver

Comment thread CHANGELOG.md Outdated
phoman14 and others added 2 commits July 8, 2026 14:48
Co-authored-by: Kelly Sovacool, PhD <kelly-sovacool@users.noreply.github.com>
@phoman14 phoman14 requested a review from kelly-sovacool July 8, 2026 18:49
kelly-sovacool and others added 3 commits July 8, 2026 15:05
* chore: add MOSuite via syncweaver

* `air format` (GitHub Actions)

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@kelly-sovacool kelly-sovacool enabled auto-merge (squash) July 8, 2026 19:26
@kelly-sovacool kelly-sovacool merged commit baad507 into main Jul 8, 2026
4 checks passed
@kelly-sovacool kelly-sovacool deleted the FigOutSync branch July 8, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants