Skip to content

Update DOI service -- reserve DOI with maformed LIDVID #480

Description

@rsjoyner

Checked for duplicates

Yes - I've already checked

🐛 Describe the bug

doi-service did not throw an error on this malformed LIDVID: urn:nasa:pds:urn:nasa:pds:odyssey_grs_cgs::1.0

The correct LIDVID (for a Bundle) is: urn:nasa:pds:odyssey_grs_cgs::1.0

🕵️ Expected behavior

I expected the doi-service to throw a wobbly and reject submission of the DOI record.

The LIDVID value should be checked to adhere to the LIDVID formation rules based on product_type.
-- Bundle LIDVID == 5
-- Collection LIDVID == 6
-- Produce LIDVID == 7

📜 To Reproduce

  1. pds-doi-cmd reserve -N ppi -s rsjoyner@jpl.nasa.gov -i DOI_reserve_dawn-vir-cruise-raw_20250925.xlsx --force > result_reserve_PPI_Dawn_VIR_Cruise_20250925.json
  2. review error log

...

🖥 Environment Info

  • Version of this software [e.g. vX.Y.Z]
  • Operating System: [e.g. MacOSX with Docker Desktop vX.Y]
    ...

📚 Version of Software Used

No response

🩺 Test Data / Additional context

Both records have malformed LIDVIDs:

DOI_reserve_grs2.xlsx

🦄 Related requirements

🦄 #xyz

⚙️ Engineering Details

No response

🎉 Integration & Test

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions