test(agent-core): align turn telemetry expectations with provider_type#1194
Merged
Conversation
Update the turn_started/turn_ended and api_error telemetry assertions to expect provider_type, matching the telemetry property rename in MoonshotAI#1184.
|
commit: |
Moixia
pushed a commit
to Moixia/idea
that referenced
this pull request
Jun 29, 2026
MoonshotAI#1194) Update the turn_started/turn_ended and api_error telemetry assertions to expect provider_type, matching the telemetry property rename in MoonshotAI#1184.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue. This fixes a CI regression introduced by #1184 ("refactor: standardize telemetry property names").
Problem
#1184 renamed the telemetry property
type→provider_typein the agent-core turn/tool telemetry (alongsidesuccess→outcomeandduration_s/latency_ms→duration_ms) and updated most affected tests, but missedpackages/agent-core/test/agent/turn.test.ts.As a result, 12 test cases failed on CI:
tracks turn_ended telemetry with protocol propstracks api_error telemetry for '429 status'…'generic step error'(11 cases)All failed with the same diff:
The implementation is the intended source of truth; the test expectations were simply stale.
What changed
Updated the three stale
type: 'kimi'expectations inturn.test.tstoprovider_type: 'kimi', covering theturn_started/turn_endedassertion and the sharedapi_errorexpected-properties object. No runtime behavior change — test-only fix.Verified locally: all 53 tests in
packages/agent-core/test/agent/turn.test.tspass.Checklist
gen-changesetsskill, or this PR needs no changeset. (Test-only change; the underlying behavior already shipped in refactor: standardize telemetry property names #1184.)gen-docsskill, or this PR needs no doc update. (No user-facing behavior change.)